This repository was archived by the owner on Nov 24, 2025. It is now read-only.
TO Postinstall: Check if hashlib.scrypt() exists before calling it#6286
Merged
ocket8888 merged 1 commit intoapache:masterfrom Oct 20, 2021
Merged
TO Postinstall: Check if hashlib.scrypt() exists before calling it#6286ocket8888 merged 1 commit intoapache:masterfrom
ocket8888 merged 1 commit intoapache:masterfrom
Conversation
ocket8888
approved these changes
Oct 20, 2021
Contributor
ocket8888
left a comment
There was a problem hiding this comment.
This looks good to me, CiaB and postinstall tests still passing, just needs a conflict fix
17df112 to
daeabeb
Compare
Member
Author
|
Rebased to fix the merge conflict in |
zrhoffman
added a commit
to zrhoffman/trafficcontrol
that referenced
this pull request
Nov 9, 2021
4 tasks
rawlinp
pushed a commit
that referenced
this pull request
Nov 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6285 by, rather than assuming that Python 3 includes
hashlib.scrypt(), checking whether it exists, and if not, using our pure Python implementation of Scrypt.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Verify that
_postinstall.hash_pass()works in Python 3 on CentOS 7.Expected output:
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist