This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Bugfix/5373 tm log inconsistency#6292
Merged
shamrickus merged 2 commits intoapache:masterfrom Oct 22, 2021
Merged
Conversation
ocket8888
added
bug
shamrickus
approved these changes
Oct 22, 2021
Member
shamrickus
left a comment
shamrickus
left a comment
There was a problem hiding this comment.
LGTM
- No duplicate messages for when caches are available.
- DS type is consistent.
Member
|
Needs conflicts resolved. |
added 2 commits
October 22, 2021 14:31
Clarify event message to account for all availability scenarios. Minor formatting for readability. Add const for consistency and clarity
tcfdev
force-pushed
the
bugfix/5373_TM-Log-Inconsistency
branch
from
493e38e to
eddfc09
Compare
zrhoffman
pushed a commit
that referenced
this pull request
Nov 5, 2021
* Removed duplicate event message. Clarify event message to account for all availability scenarios. Minor formatting for readability. Add const for consistency and clarity * Add changelog entry Co-authored-by: Taylor Frey <taylor_frey@comcast.com> (cherry picked from commit 23408ab)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #5373
This is in response to a bug filed in reporting in Traffic Monitor.
The event log appeared to have duplicated messages for delivery services with slightly different information within the fields. This will address the issue by:
constfor ensure clarity in event messageTypeWhich Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Ensure
go test ./...succeeds from thetraffic_monitorproject directory.Ensure CIAB builds successfully. While running CIAB, perform a change resulting in a Delivery Service's availability. The Event will appear in the
/publish/EventLogendpoint.PR submission checklist