This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix json response for invalid invalidation job. Moved CHANGELOG entry#6328
Merged
mattjackson220 merged 1 commit intoapache:masterfrom Nov 4, 2021
Merged
Conversation
Member
If you put that in a separate PR, I'll merge it right away |
srijeet0406
approved these changes
Nov 3, 2021
Contributor
srijeet0406
left a comment
There was a problem hiding this comment.
LGTM! Manual tests pass. API and unit tests pass.
Contributor
|
retest this please |
Member
Failing due to the ATS RPM version-calculating issue fixed by #6329 |
Member
|
In order for CI to pass, #6328 needs to be rebased onto the git remote add apache git@github.com:apache/trafficcontrol.git
git fetch apache
git rebase apache
git push your-fork your-branch --force |
5f1111e to
56204c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses an issue discovered in testing the TO v4.0
/jobsendpoint. The validation of the incoming job was wrapping the alert and error response inside another alert and error response.Incorrect response:
{ "alerts": [ { "text": "{\"alerts\":[{\"text\":\"deliveryService: cannot be blank.\",\"level\":\"error\"}]}\n", "level": "error" } ] }Fixed response:
{ "alerts": [ { "text": "deliveryService: cannot be blank.", "level": "error" } ] }Also moved a CHANGELOG entry for the REFETCH feature into the correct location for the CHANGELOG.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run Traffic Ops and attempt to POST a new invalidation request to the
/jobsendpoint. The following json will trigger a validation error, alert response:{ "startTime": "2021-11-05T16:24:00.370Z", "regex": "/path/to/some/content\\.jpg", "ttlHours": 24, "invalidationType": "REFRESH" }PR submission checklist