This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Take topology-based DSes into account when checking DSS assignments#6408
Merged
zrhoffman merged 3 commits intoapache:masterfrom Dec 6, 2021
Merged
Conversation
In order to prevent accidental ouages, TO currently has validation which prevents things like deleting the last server that is assigned to an active delivery service. However, this validation ignored the fact that delivery services can now be assigned to a topology instead of using DSS assignments. This prevents a number of actually valid things, such as safely setting caches to ADMIN_DOWN, assigning MSO servers to topology-based DSes, and removing legacy DSS EDGE assignments from topology-based DSes. This fixes that validation in order to take topology-based DSes into account. Closes: apache#6392
rawlinp
added
bug
Contributor
Author
|
Note: I do intend to add some TO API tests for this PR -- I just wanted to get the review/test process started. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to prevent accidental outages, TO currently has validation which
prevents things like deleting the last server that is assigned to an
active delivery service. However, this validation ignored the fact that
delivery services can now be assigned to a topology instead of using DSS
assignments. This prevents a number of actually valid things, such as
safely setting caches to ADMIN_DOWN, assigning MSO servers to
topology-based DSes, and removing legacy DSS EDGE assignments from
topology-based DSes. This fixes that validation in order to take
topology-based DSes into account.
Closes: #6392
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Ensure the TO API tests pass.
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist