Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

TM should not overwrite monitoring snapshot data with crconfig snapsot data#6443

Merged
shamrickus merged 3 commits intoapache:masterfrom
srijeet0406:TM_override_data
Jan 7, 2022
Merged

TM should not overwrite monitoring snapshot data with crconfig snapsot data#6443
shamrickus merged 3 commits intoapache:masterfrom
srijeet0406:TM_override_data

Conversation

@srijeet0406
Copy link
Copy Markdown
Contributor

This PR closes #6376


Which Traffic Control components are affected by this PR?

  • Traffic Monitor
  • Traffic Ops

What is the best way to verify this PR?

Make sure all the tests run. Follow the steps in #6376 and make sure you see the expected results.

If this is a bugfix, which Traffic Control versions contained the bug?

  • master

PR submission checklist

@zrhoffman zrhoffman added improvement The functionality exists but it could be improved in some way. low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution Traffic Monitor related to Traffic Monitor Traffic Ops related to Traffic Ops labels Jan 3, 2022
Copy link
Copy Markdown
Collaborator

@tcfdev tcfdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round :)

Comment thread traffic_monitor/towrap/towrap.go Outdated
Comment thread traffic_monitor/towrap/towrap.go Outdated
Comment thread traffic_monitor/towrap/towrap.go Outdated
Comment thread traffic_monitor/towrap/towrap.go
Comment thread traffic_ops/traffic_ops_golang/monitoring/monitoring.go
Comment thread traffic_ops/traffic_ops_golang/monitoring/monitoring.go Outdated
Comment thread traffic_ops/traffic_ops_golang/monitoring/monitoring_test.go Outdated
Copy link
Copy Markdown
Collaborator

@tcfdev tcfdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last code comment clean and then it LGTM! Ran it briefly in a test environment and all appears to be working as intended.

Comment thread traffic_monitor/towrap/towrap.go Outdated
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

improvement The functionality exists but it could be improved in some way. low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution Traffic Monitor related to Traffic Monitor Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TM should not need to overwrite monitoring snapshot data with CRConfig snapshot data

4 participants