This repository was archived by the owner on Nov 24, 2025. It is now read-only.
TR logging: Archive logs using an integer counter#6450
Merged
srijeet0406 merged 2 commits intoapache:masterfrom Jan 7, 2022
Merged
TR logging: Archive logs using an integer counter#6450srijeet0406 merged 2 commits intoapache:masterfrom
srijeet0406 merged 2 commits intoapache:masterfrom
Conversation
srijeet0406
approved these changes
Jan 7, 2022
Contributor
srijeet0406
left a comment
There was a problem hiding this comment.
Code looks good. Tested manually on CIAB to make sure the output is as expected. LGTM!
ocket8888
pushed a commit
that referenced
this pull request
Jan 12, 2022
* Archive logs using an integer counter * Keep a maximum of 1 archive of traffic_router.log (traffic_router.log.1) (cherry picked from commit 47e7e66)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6450 fixes #6446 by revert the Traffic Router rollover file patterns to the one previously used in
log4j.propertieswith Log4j 1.2, as well as ensuring thattraffic_router.logonly keeps 1 archive.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
SizeBasedTriggeringPolicyinlog4j2.xmlfrom200MBand100MBto1MBso log file rollovers happen more frequentlyaccess.log,access.log.1,traffic_router.log, andtraffic_router.log.1with content so they are over 1MB in size:traffic_router.logrolls over, resulting in the oldtraffic_router.logbeing moved totraffic_router.log.1and the oldtraffic_router.log.1being removedaccess.logrolls over 10 times.access.log:If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist