TPv2 Testing improvements

experimental/traffic-portal/.eslintrc.json

@@ -161,6 +161,7 @@
 						"allowWithDecorator": true
 					}
 				],
+				"@typescript-eslint/no-duplicate-imports": ["error"],
 				"@typescript-eslint/no-dynamic-delete": "error",
 				"@typescript-eslint/no-floating-promises": "off",
 				"@typescript-eslint/no-inferrable-types": [
@@ -200,6 +201,8 @@
 					"error"
 				],
 				"@typescript-eslint/typedef": "off",
+				"jsdoc/no-types": "error",
+				"jsdoc/require-description": "error",
 				"jsdoc/require-jsdoc": [
 					"error",
 					{
@@ -217,7 +220,8 @@
 						},
 						"checkConstructors": false,
 						"checkGetters": true,
-						"checkSetters": true
+						"checkSetters": true,
+						"enableFixer": false
 					}
 				],
 				"@typescript-eslint/unbound-method": "error",
@@ -232,14 +236,68 @@
 					"1tbs"
 				],
 				"class-methods-use-this": "off",
-				"import/order": "error",
+				"import/export": "error",
+				"import/first": "error",
+				"import/newline-after-import": "error",
+				"import/no-cycle": [
+					"error",
+					{
+						"ignoreExternal": true
+					}
+				],
+				"import/no-self-import": "error",
+				"import/no-useless-path-segments": [
+					"error",
+					{
+						"commonjs": true,
+						"noUselessIndex": true
+					}
+				],
+				"import/order": [
+					"error",
+					{
+						"alphabetize": {"order": "asc"},
+						"groups": [
+							"builtin",
+							"external",
+							"internal",
+							"parent",
+							"sibling"
+						],
+						"pathGroups": [
+							{
+								"group": "builtin",
+								"pattern": "zone.js/**/*",
+								"position": "before"
+							},
+							{
+								"group": "external",
+								"pattern": "(@(angular|fortawesome)|chart.js|rxjs)*/**/*",
+								"position": "before"
+							},
+							{
+								"group": "internal",
+								"pattern": "src/**/*"
+							}
+						],
+						"pathGroupsExcludedImportTypes": [
+							"zone.js/**/*",
+							"@angular*/**/*",
+							"@fortawesome*/**/*",
+							"chart.js",
+							"rxjs"
+						],
+						"newlines-between": "always",
+						"warnOnUnassignedImports": true
+					}
+				],
 				"linebreak-style": [
 					"error",
 					"unix"
 				],
 				"no-bitwise": "off",
 				"no-duplicate-case": "error",
-				"no-duplicate-imports": "error",
+				"no-duplicate-imports": "off",
 				"no-else-return": "error",
 				"no-empty": "error",
 				"no-extra-bind": "error",
@@ -249,8 +307,27 @@
 						"capIsConstructor": false
 					}
 				],
+				"no-multiple-empty-lines": [
+					"error",
+					{
+						"max": 1,
+						"maxBOF": 0,
+						"maxEOF": 0
+					}
+				],
 				"no-new-func": "error",
 				"no-redeclare": "off",
+				"no-restricted-imports": [
+					"error",
+					{
+						"patterns": [
+							{
+								"message": "Going up more than one directory for an import is overly complex; use an import path that starts with 'src/' instead",
+								"group": ["../../*"]
+							}
+						]
+					}
+				],
 				"no-return-await": "error",
 				"no-sparse-arrays": "error",
 				"no-template-curly-in-string": "error",

experimental/traffic-portal/angular.json

@@ -96,6 +96,7 @@
 					"builder": "@angular-devkit/build-angular:karma",
 					"options": {
 						"main": "src/test.ts",
+						"codeCoverageExclude": ["src/app/api/**/*"],
 						"polyfills": "src/polyfills.ts",
 						"tsConfig": "tsconfig.spec.json",
 						"karmaConfig": "karma.conf.js",

experimental/traffic-portal/documentation.styles/style.css

@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+@import "./reset.css";
+@import "./bootstrap.min.css";
+@import "./bootstrap-card.css";
+@import "./prism.css";
+@import "./ionicons.min.css";
+@import "./compodoc.css";
+@import "./tablesort.css";
+
+.img-responsive[data-type="custom-logo"] {
+	max-height: 150px;
+	display: block;
+	margin: auto;
+}

experimental/traffic-portal/karma.conf.js

@@ -23,15 +23,16 @@ module.exports = function (config) {
 			require("karma-jasmine"),
 			require("karma-chrome-launcher"),
 			require("karma-jasmine-html-reporter"),
-			require("karma-coverage-istanbul-reporter"),
+			require("karma-coverage"),
 			require("@angular-devkit/build-angular/plugins/karma")
 		],
 		client: {
 			clearContext: false // leave Jasmine Spec Runner output visible in browser
 		},
-		coverageIstanbulReporter: {
+		coverageReporter: {
 			dir: require("path").join(__dirname, "./coverage/traffic-portal"),
-			reports: ["html", "lcovonly", "text-summary"],
+			reports: [{type: "html"}, {type: "text-summary"}],
+			subdir: ".",
 			fixWebpackSourcePaths: true
 		},
 		reporters: ["progress", "kjhtml"],