Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Fix incorrect template strings#6595

Merged
zrhoffman merged 1 commit intoapache:masterfrom
ocket8888:fix-pr-gha
Mar 1, 2022
Merged

Fix incorrect template strings#6595
zrhoffman merged 1 commit intoapache:masterfrom
ocket8888:fix-pr-gha

Conversation

@ocket8888
Copy link
Copy Markdown
Contributor

This PR fixes an issue introduced in #6532 where some template strings use Javascript syntax like

`${variableName}`;

but they should use Python syntax like

f"{variable_name}"

Which Traffic Control components are affected by this PR?

  • GitHub Actions

What is the best way to verify this PR?

Run the GHA on your fork, verify the resulting PR

If this is a bugfix, which Traffic Control versions contained the bug?

  • master

PR submission checklist

  • This PR has tests
  • This PR has documentation
  • This PR has a CHANGELOG.md entry
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@ocket8888 ocket8888 added bug something isn't working as intended low impact affects only a small portion of a CDN, and cannot itself break one authentication Relating to login, registration, passwords, tokens, etc. labels Mar 1, 2022
@ocket8888 ocket8888 requested a review from zrhoffman March 1, 2022 18:57
@zrhoffman zrhoffman merged commit 8759dfb into apache:master Mar 1, 2022
@ocket8888 ocket8888 deleted the fix-pr-gha branch March 1, 2022 19:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

authentication Relating to login, registration, passwords, tokens, etc. bug something isn't working as intended low impact affects only a small portion of a CDN, and cannot itself break one

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants