This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix the "PR-to-Update-Go" GitHub Action#6605
Merged
zrhoffman merged 23 commits intoapache:masterfrom Mar 3, 2022
Merged
Conversation
May need to revert this, not sure it'll work
The separation makes it testable
ocket8888
added
bug
zrhoffman
suggested changes
Mar 3, 2022
Member
zrhoffman
left a comment
zrhoffman
left a comment
There was a problem hiding this comment.
Wow, thanks for documenting all of this, it's way more maintainable now. Just 1 URL to change and then it should be good.
zrhoffman
approved these changes
Mar 3, 2022
Member
zrhoffman
left a comment
zrhoffman
left a comment
There was a problem hiding this comment.
- Unit tests pass
- Doctests pass
- Go PR is generated correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the GHA for opening PRs to update our Go version, which has been broken in some fashion since #6532 was merged.
This also expands doctest coverage a bit, makes those easier to run, fixes the broken unit tests, fixes strict typing compliance, and fixes a myriad of linting problems.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
What I did was change the contents of GO_VERSION on my fork's
masterbranch to1.17.6and ran the action via manual trigger, verified that it opened a PR to update that file and also.env- see ocket8888#53. To run the unit tests useTo run the doctests use
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist