Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Adding status and lastPoll fields to CrStates#6612

Merged
rawlinp merged 5 commits intoapache:masterfrom
srijeet0406:add_status_last_polled_fields_to_crstates
Mar 14, 2022
Merged

Adding status and lastPoll fields to CrStates#6612
rawlinp merged 5 commits intoapache:masterfrom
srijeet0406:add_status_last_polled_fields_to_crstates

Conversation

@srijeet0406
Copy link
Copy Markdown
Contributor

@srijeet0406 srijeet0406 commented Mar 3, 2022 •
edited by rawlinp
Loading

This PR closes #6448

Which Traffic Control components are affected by this PR?

  • Traffic Monitor

What is the best way to verify this PR?

Run TM locally and GET the publish/CrStates endpoint. Make sure the status and lastPoll fields show up in the output. Also confirm that the status for the caches is in fact what's being reported by the api/cache-statuses endpoint.

If this is a bugfix, which Traffic Control versions contained the bug?

  • master

PR submission checklist

@srijeet0406 srijeet0406 added the Traffic Monitor related to Traffic Monitor label Mar 3, 2022
ocket8888
ocket8888 reviewed Mar 3, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you want to take this opportunity to fill out our missing docs for /publish/CrStates?

rawlinp
rawlinp suggested changes Mar 3, 2022
View reviewed changes
Comment thread lib/go-tc/crstates.go Outdated
Comment thread docs/source/development/traffic_monitor/traffic_monitor_api.rst Outdated
Comment thread docs/source/development/traffic_monitor/traffic_monitor_api.rst Outdated
rawlinp
rawlinp suggested changes Mar 10, 2022
View reviewed changes
Comment thread docs/source/development/traffic_monitor/traffic_monitor_api.rst
Comment thread docs/source/development/traffic_monitor/traffic_monitor_api.rst
@rawlinp rawlinp changed the title Adding status and lastHmPoll fields to CrStates Adding status and lastPoll fields to CrStates Mar 10, 2022
@rawlinp rawlinp added the new feature A new feature, capability or behavior label Mar 10, 2022
@rawlinp rawlinp merged commit 4924be4 into apache:master Mar 14, 2022
@ocket8888 ocket8888 mentioned this pull request Mar 15, 2022
Merged
4 tasks
@jrushford jrushford mentioned this pull request Mar 17, 2022
Merged
3 tasks
jrushford added a commit to jrushford/trafficcontrol that referenced this pull request Mar 21, 2022
@jrushford
Restores logging the cache status.
961f0c1 
When the tc-health-client was switched to using the combined
TM CrStates endpoint, the ability to log the cache status was
lost, Issue apache#6448.  PR apache#6612 adds the cache status field to the
TM CrStates endpoint allowing cache status to be logged again.
This PR adds back the cache status logging.
rawlinp pushed a commit that referenced this pull request Mar 30, 2022
@jrushford
Restores logging the cache status. (#6667)
55dde3c 
When the tc-health-client was switched to using the combined
TM CrStates endpoint, the ability to log the cache status was
lost, Issue #6448.  PR #6612 adds the cache status field to the
TM CrStates endpoint allowing cache status to be logged again.
This PR adds back the cache status logging.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@ocket8888 ocket8888 ocket8888 left review comments

@rawlinp rawlinp rawlinp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

new feature A new feature, capability or behavior Traffic Monitor related to Traffic Monitor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add the cache status field to the Traffic Monitor CrStates endpoint

3 participants

@srijeet0406 @ocket8888 @rawlinp