Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Prebuild trafficserver for Dev CDN-in-a-Box#6699

Merged
ocket8888 merged 20 commits intoapache:masterfrom
zrhoffman:ghcr.io/apache/trafficcontrol/ci/trafficserver-alpine
Apr 1, 2022
Merged

Prebuild trafficserver for Dev CDN-in-a-Box#6699
ocket8888 merged 20 commits intoapache:masterfrom
zrhoffman:ghcr.io/apache/trafficcontrol/ci/trafficserver-alpine

Conversation

@zrhoffman
Copy link
Copy Markdown
Member

This PR


Which Traffic Control components are affected by this PR?

  • Dev CDN in a Box
  • Automation - GitHub Container Registry

What is the best way to verify this PR?

  1. Push the zrhoffman:ghcr.io/apache/trafficcontrol/ci/trafficserver-alpine branch to the master branch of your Traffic Control fork
  2. Go to your fork -> Actions -> Container ghcr.io/apache/trafficcontrol/ci/trafficserver-alpine workflow and manually trigger the worflow
  3. Wait for the workflow to complete (~14 minutes)
  4. Verify that https://github.com/<Your Fork>/trafficcontrol/pkgs/container/trafficcontrol/ci/trafficserver-alpine was created

PR submission checklist

@zrhoffman zrhoffman added performance impacts/improves/measures performance automation related to automated testing/deployment/packaging etc. dev-ciab Related to CDN in a Box for Developers labels Mar 29, 2022
@zrhoffman zrhoffman force-pushed the ghcr.io/apache/trafficcontrol/ci/trafficserver-alpine branch from ef1396f to d1b60b2 Compare March 29, 2022 15:22
Comment thread .env
@zrhoffman zrhoffman requested a review from ocket8888 March 29, 2022 18:03
@zrhoffman zrhoffman force-pushed the ghcr.io/apache/trafficcontrol/ci/trafficserver-alpine branch from 465470a to 9c35f74 Compare March 29, 2022 18:17
@zrhoffman
Copy link
Copy Markdown
Member Author

Okay, done making changes

@ocket8888
Copy link
Copy Markdown
Contributor

Overwriting only the Go version in this file in 9d1b0fe

Do you have a place you already tested that that I could look at to see it working?

@zrhoffman
Copy link
Copy Markdown
Member Author

zrhoffman commented Mar 29, 2022

Overwriting only the Go version in this file in 9d1b0fe

Do you have a place you already tested that that I could look at to see it working?

Sure, it's passing on my fork here

Edit: Linked to a run from after I removed quoting
Edit edit: Linked to a run that uses kwargs
Edit edit edit: Linked to a run that updates GO_VERSION and .env in a single tree
Edit edit edit edit: Linked to a run where author and committer are conditionally set if author exists
Edit edit edit edit edit: Linked to a run using PurePath
Edit edit edit edit edit: Linked to a run that does not use kwargs anymore

Comment thread .github/actions/pr-to-update-go/pr_to_update_go/go_pr_maker.py Outdated
@zrhoffman zrhoffman force-pushed the ghcr.io/apache/trafficcontrol/ci/trafficserver-alpine branch from 9621def to 137bb0a Compare March 29, 2022 21:12
@zrhoffman zrhoffman requested a review from ocket8888 March 29, 2022 21:19
@zrhoffman zrhoffman removed the performance impacts/improves/measures performance label Mar 30, 2022
@zrhoffman zrhoffman added the performance impacts/improves/measures performance label Mar 31, 2022
@ocket8888 ocket8888 merged commit f4f96b4 into apache:master Apr 1, 2022
@zrhoffman zrhoffman deleted the ghcr.io/apache/trafficcontrol/ci/trafficserver-alpine branch April 2, 2022 05:22
@zrhoffman zrhoffman added the Traffic Server related to Apache Traffic Server label Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automation related to automated testing/deployment/packaging etc. dev-ciab Related to CDN in a Box for Developers performance impacts/improves/measures performance Traffic Server related to Apache Traffic Server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants