This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix TM issue where CRConfig is never updated#6748
Merged
ocket8888 merged 2 commits intoapache:masterfrom Apr 13, 2022
Merged
Conversation
PR apache#6625 reduced the TM dependency on CRConfig data, but it accidentally caused TM to no longer poll for new CRConfig snapshots. This adds the CRConfig request back into the polling loop so that it updates its in-memory copy for internal use (if necessary) and for serving to TR.
rawlinp
added
bug
Contributor
|
Go Format failure is a bug in Go (see golang/go#52333) |
ocket8888
approved these changes
Apr 13, 2022
Contributor
ocket8888
left a comment
ocket8888
left a comment
There was a problem hiding this comment.
Tests pass now that we have a workaround for the VCS issue
zrhoffman
pushed a commit
to zrhoffman/trafficcontrol
that referenced
this pull request
Oct 2, 2022
* Fix TM issue where CRConfig is never updated PR apache#6625 reduced the TM dependency on CRConfig data, but it accidentally caused TM to no longer poll for new CRConfig snapshots. This adds the CRConfig request back into the polling loop so that it updates its in-memory copy for internal use (if necessary) and for serving to TR. * Add --buildvcs=false to 'go test' action
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #6625 reduced the TM dependency on CRConfig data, but it accidentally
caused TM to no longer poll for new CRConfig snapshots. This adds the
CRConfig request back into the polling loop so that it updates its
in-memory copy for internal use (if necessary) and for serving to TR.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Start TM, then take a new snapshot, and ensure that TM updates its crconfig.backup file with the new snapshot and serves the new snapshot via its
/publish/CrConfigendpoint.If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist