Fix internal server error and false positive when creating a server

[ericholguin]

Fixes: #6779
Fixes: #6781

With this fix there is no internal server error when creating a server without a profile key in v2 and v3

The other fix is when creating a server with multiple profiles in v4, if any of the profiles do not belong to the same CDN it will now fail as expected.

---

Which Traffic Control components are affected by this PR?

• Traffic Ops

What is the best way to verify this PR?

Build and test the following in TO:

POST request to /api/2.0/servers with no profile key in the request body

{
    "cachegroupId": 8,
    "cdnId": 2,
    "domainName": "ga.atlanta.kabletown.net",
    "hostName": "atlanta-edge-01",
    "interfaceMtu": 1500,
    "ipAddress": "172.16.239.120",
    "ipGateway": "172.16.239.1",
    "ipNetmask": "255.255.255.0",
    "ipIsService": true,
    "interfaceName": "eth0",
    "physLocationId": 2,
    "statusId": 3,
    "typeId": 11,
    "profileId": 13
}

Should succeed with no error:

HTTP/1.1 200 OK
{
    "alerts": [
        {
            "text": "Server created",
            "level": "success"
        }
    ],
    "response": {...}
}

POST request to /api/3.0/servers with no profile key in the request body

{
    "cachegroupId": 8,
    "cdnId": 2,
    "domainName": "ga.atlanta.kabletown.net",
    "hostName": "atlanta-edge-01",
    "interfaces": [
        {
            "ipAddresses": [
                {
                    "address": "0.0.0.1",
                    "gateway": "0.0.0.1",
                    "serviceAddress": true
                }
            ],
            "name": "eth0"
        }
    ],
    "physLocationId": 2,
    "statusId": 3,
    "typeId": 11,
    "profileId": 13
}

Should succeed with no error:

HTTP/1.1 201 Created
{
    "alerts": [
        {
            "text": "Server created",
            "level": "success"
        }
    ],
    "response": {...}
}

POST request to /api/4.0/servers with multiple profiles, where one profile belongs to a different cdn than the server (regardless of order)

{
    "cachegroupId": 8,
    "cdnId": 2,
    "domainName": "test.net",
    "hostName": "test-01",
    "interfaces": [
        {
            "ipAddresses": [
                {
                    "address": "0.0.0.1",
                    "gateway": "0.0.0.1",
                    "serviceAddress": true
                }
            ],
            "name": "eth0"
        }
    ],
    "physLocationId": 2,
    "statusId": 3,
    "typeId": 11,
    "profileNames": ["ORG_MSO", "TRAFFIC_STATS", "CCR_CIAB"]
}

Should return an error:

HTTP/1.1 400 Bad Request
{
    "alerts": [
        {
            "text": "CDN id '1' for profile 'TRAFFIC_STATS' does not match Server CDN '2'",
            "level": "error"
        }
    ]
}

PR submission checklist

• This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

[mitchell852]

can you make a better title for the PR @ericholguin to describe what this PR does? thanks

[rimashah25]

LGTM from code perspective but wonder why TO API tests fail..