This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Remove Traffic Ops API version 2#6945
Merged
ocket8888 merged 14 commits intoapache:masterfrom Jul 11, 2022
Merged
Conversation
zrhoffman
added
Traffic Ops
Contributor
|
It appears that the |
rawlinp
suggested changes
Jul 8, 2022
ericholguin
reviewed
Jul 8, 2022
Member
Author
Fixed in 9e4ad30 |
rawlinp
reviewed
Jul 8, 2022
rawlinp
approved these changes
Jul 8, 2022
Contributor
rawlinp
left a comment
rawlinp
left a comment
There was a problem hiding this comment.
All my comments have been addressed, but I'll wait for the other reviewers to approve as well.
ericholguin
reviewed
Jul 8, 2022
Contributor
ericholguin
left a comment
ericholguin
left a comment
There was a problem hiding this comment.
Can the traffic_ops/testing/api//v2 folder be removed as well, I'm still seeing it
Member
Author
folder gitignore removed in a712983 |
ericholguin
approved these changes
Jul 8, 2022
ocket8888
approved these changes
Jul 11, 2022
Contributor
ocket8888
left a comment
ocket8888
left a comment
There was a problem hiding this comment.
my concerns were addressed
This was referenced Jul 11, 2022
zrhoffman
added a commit
to zrhoffman/trafficcontrol
that referenced
this pull request
Oct 2, 2022
* Remove Traffic Ops API v2 tests * Remove Traffic Ops v2 Go client library * Remove newly-unused handlers * Use latest to-api-cdns-dnsseckeys-generate label in Python Traffic Ops client * Remove Traffic Ops API v2 routes * Remove API v2-specific logic * Remove more API v2-specific logic * Re-add API v3 handling for DSes * Re-add API v3 Delivery Service Read() handling * Remove more lines in the Dockerfile referencing the API v2 tests and client * Remove more unused functions * Consolidate queryParam map * Remove API v2 tests gitignore * Remove mention of API v2 from comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #6697 by removing Traffic Ops API v2, logic relating to API v2, and the v2 client and API tests.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Request TO API v2 routes, verify you get HTTP status code 501 Not Implemented:
{ "alerts": [ { "level": "error", "text": "The requested api version is not implemented by this server. If you are using a newer client with an older server, you will need to use an older client version or upgrade your server." } ] }PR submission checklist