This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Prevent RequestedName field from being returned in Topologies and Ser…#6970
Merged
ocket8888 merged 2 commits intoapache:masterfrom Jul 18, 2022
Merged
Prevent RequestedName field from being returned in Topologies and Ser…#6970ocket8888 merged 2 commits intoapache:masterfrom
ocket8888 merged 2 commits intoapache:masterfrom
Conversation
ocket8888
added
Traffic Ops
ocket8888
approved these changes
Jul 18, 2022
Contributor
ocket8888
left a comment
ocket8888
left a comment
There was a problem hiding this comment.
Confirmed that the extra field is no longer present in responses
4 tasks
zrhoffman
pushed a commit
to zrhoffman/trafficcontrol
that referenced
this pull request
Oct 2, 2022
…ver Capability responses (apache#6970) Co-authored-by: Taylor Frey <taylor_frey@comcast.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #6792
The same field (
RequestedName) was added to the structs in use with the Topology and Server Capability endpoints. This field is undocumented in it's response and should not be returned in POST or PUT responses (or any such http verbs). This fix simply prevents the response from returning said fields to match expected behavior and documentation.Additionally, a small edit was made to the documentation to remove an incorrect part of the URL.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Verify that POST and PUT responses do not contain the
RequestedNamefield in the JSON response.If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist