This repository was archived by the owner on Nov 24, 2025. It is now read-only.
[TO] Added a new route and logic for assigning multiple server capabilities to a server#6996
Merged
ocket8888 merged 19 commits intoapache:masterfrom Aug 9, 2022
Merged
Conversation
…e/multiple_server_capabilities � Conflicts: � traffic_ops/testing/api/v4/serverservercapability_test.go
ocket8888
reviewed
Aug 2, 2022
Contributor
ocket8888
left a comment
There was a problem hiding this comment.
Did you consider just adding the ability to submit an array of capabilities to server_server_capabilities instead of making an endpoint? If so, why did you decide against it?
ocket8888
reviewed
Aug 4, 2022
…e/multiple_server_capabilities � Conflicts: � CHANGELOG.md
ocket8888
reviewed
Aug 8, 2022
ocket8888
reviewed
Aug 8, 2022
Contributor
ocket8888
left a comment
There was a problem hiding this comment.
The endpoint seems to work well from testing. Just a couple of minor comments.
This reverts commit 8181b51.
ocket8888
approved these changes
Aug 9, 2022
zrhoffman
pushed a commit
to zrhoffman/trafficcontrol
that referenced
this pull request
Oct 2, 2022
…s to a server (apache#6996) * Added a new route and logic for assigning multiple server capabilities to a server. * Added tests for assigning multiple server capabilities to a server. * Updated CHANGELOG.md * Updated test based on latest table driven model * Added documentation for new route. * Fixed spacing. * Fixed spacing. * Updated based on review comments. * Updated based on review comments-1. * Added both API versions to allow client flexibility. * Updated order of API versions. * Removed `id` parameter. * Updated based on another set of review comments. * Updated test based on route change * updated format. * Revert "updated format." This reverts commit 8181b51. * removed format and updated docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #7088
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Using curl cmds test the new route with a list of server capabilities
curl -X PUT -k -H "Accept: application/json" --cookie "mojolicious=" --data @msc.json https://localhost:port/api/4.1/multiple_server_capabilities/106
curl -X PUT -k -H "Accept: application/json" --cookie "mojolicious==" --data @msc.json https://localhost:port/api/4.1/multiple_server_capabilities/3
curl -X PUT -k -H "Accept: application/json" --cookie "mojolicious==" --data @msc.json https://localhost:port/api/4.0/multiple_server_capabilities/3
PR submission checklist