Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

[TPv1] Added a new route and logic for assigning multiple server capabilities to a server#7020

Merged
srijeet0406 merged 5 commits intoapache:masterfrom
rimashah25:feature/tpv1-assign-multiple-scs
Aug 22, 2022
Merged

[TPv1] Added a new route and logic for assigning multiple server capabilities to a server#7020
srijeet0406 merged 5 commits intoapache:masterfrom
rimashah25:feature/tpv1-assign-multiple-scs

Conversation

@rimashah25
Copy link
Copy Markdown
Contributor

@rimashah25 rimashah25 commented Aug 12, 2022 •
edited
Loading

Closes: #7088

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

  1. Once you create a server, click on Manage Capabilities
  2. To assign multiple capabilities to a server, click on image
  3. A new dialog window listing all server capabilities (and the one assigned to the existing server as checked) should open up, like this:
    image
  4. You can chose from the list and click submit and then see it update on the server/<server_name>/capabilties table.

PR submission checklist

@rimashah25 rimashah25 marked this pull request as ready for review August 12, 2022 19:30
@ocket8888 ocket8888 added new feature A new feature, capability or behavior Traffic Portal v1 related to Traffic Portal version 1 medium impact impacts a significant portion of a CDN, or has the potential to do so labels Aug 15, 2022
srijeet0406
srijeet0406 reviewed Aug 15, 2022
View reviewed changes
Comment thread traffic_portal/app/src/scripts/config.js Outdated
Comment thread ..._portal/app/src/common/modules/table/serverServerCapabilities/table.assignServerSCs.tpl.html
Comment thread ...rtal/app/src/common/modules/table/serverServerCapabilities/TableAssignServerSCsController.js
@rimashah25 rimashah25 requested a review from srijeet0406 August 18, 2022 16:26
srijeet0406
srijeet0406 approved these changes Aug 22, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@srijeet0406 srijeet0406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Tested manually and everything seems to work fine. All tests pass.

@srijeet0406 srijeet0406 merged commit e576a61 into apache:master Aug 22, 2022
@srijeet0406 srijeet0406 mentioned this pull request Sep 19, 2022
Closed
@asf-ci asf-ci mentioned this pull request Oct 1, 2022
Merged
4 tasks
zrhoffman pushed a commit to zrhoffman/trafficcontrol that referenced this pull request Oct 2, 2022
@rimashah25
[TPv1] Added a new route and logic for assigning multiple server capa…
6779307 
…bilities to a server (apache#7020)

* Added logic for assigning multiple server capabilities in TPv1

* Updated CHANGELOG.md

* Updated based on review comments.

* Updated CHANGELOG.md based on merge conflicts.
@rimashah25 rimashah25 deleted the feature/tpv1-assign-multiple-scs branch February 8, 2023 21:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@srijeet0406 srijeet0406 srijeet0406 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

medium impact impacts a significant portion of a CDN, or has the potential to do so new feature A new feature, capability or behavior Traffic Portal v1 related to Traffic Portal version 1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add ability to assign multiple server capabilities to a server

3 participants

@rimashah25 @srijeet0406 @ocket8888