This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Add configuration setting for TO client request timeout#7050
Merged
srijeet0406 merged 3 commits intoapache:masterfrom Oct 13, 2022
Merged
Add configuration setting for TO client request timeout#7050srijeet0406 merged 3 commits intoapache:masterfrom
srijeet0406 merged 3 commits intoapache:masterfrom
Conversation
srijeet0406
reviewed
Oct 5, 2022
f1e5f17 to
13293d0
Compare
srijeet0406
approved these changes
Oct 13, 2022
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #7048
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Ensure the all tests (especially CDN-in-a-box) continues to work and run. Traffic Stats should run whether the configuration value is present or not. It will default to the previous hard coded 10 seconds. However, now it should also accept the new "toRequestTimeout" value in the .cfg file.
As this requires an unresponsive/slow TO instance, testing can be difficult. This can be done locally with a debug build and breakpoints. You can put a breakpoint at the beginning of the TO GET v3.1/servers endpoint and waiting longer the alloted time (be it the 10 second default or whatever custom value you place) which will prevent Traffic Stats from receiving a response in time and cause the error to appear in the log. The error is:
The next time through you can remove the breakpoint and allow it to proceed normally. The error will not appear and TS will function normally.
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist