Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Renamed rascal to tm/traffic_monitor#7068

Merged
ocket8888 merged 11 commits intoapache:masterfrom
rimashah25:refactor/rascal_to_tm
Nov 1, 2022
Merged

Renamed rascal to tm/traffic_monitor#7068
ocket8888 merged 11 commits intoapache:masterfrom
rimashah25:refactor/rascal_to_tm

Conversation

@rimashah25
Copy link
Copy Markdown
Contributor

@rimashah25 rimashah25 commented Sep 8, 2022 •
edited
Loading

Closes: #2564 from RASCAL (Traffic Monitor) Perspective

Which Traffic Control components are affected by this PR?

  • Documentation
  • Traffic Control Cache Config (t3c, formerly ORT)
  • Traffic Control Health Client (tc-health-client)
  • Traffic Control Client
  • Traffic Monitor
  • Traffic Ops
  • CDN in a Box
  • Automation

What is the best way to verify this PR?

  1. Run integration, unit test.
  2. Ensure CIAB build correctly
  3. TO API endpoints work as expected.
  4. Clients (eg: T3C) work as expected.

If this is a bugfix, which Traffic Control versions contained the bug?

PR submission checklist

@rimashah25 rimashah25 marked this pull request as ready for review September 8, 2022 19:20
@rawlinp rawlinp added Traffic Ops related to Traffic Ops Traffic Router related to Traffic Router Traffic Stats related to Traffic Stats Traffic Monitor related to Traffic Monitor Traffic Portal v1 related to Traffic Portal version 1 documentation related to documentation cache-config Cache config generation tc-health-client Traffic Control Health Client and removed Traffic Router related to Traffic Router Traffic Stats related to Traffic Stats Traffic Portal v1 related to Traffic Portal version 1 labels Sep 9, 2022
rawlinp
rawlinp suggested changes Sep 9, 2022
View reviewed changes
Comment thread traffic_ops/traffic_ops_golang/cdn/capacity.go Outdated
Comment thread traffic_ops/traffic_ops_golang/deliveryservice/capacity.go Outdated
Comment thread traffic_ops/traffic_ops_golang/monitoring/monitoring.go Outdated
Comment thread docs/source/admin/traffic_router.rst Outdated
@ocket8888 ocket8888 self-assigned this Sep 19, 2022
ocket8888
ocket8888 suggested changes Sep 29, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Rawlin said, we can't just change what TO is querying for when it looks for Parameters or servers etc. That would break a lot of things on install, that would take a while to fix by hand through the API. In a database migration, though, it should be pretty simple to swap out the old names for the new ones.

Comment thread docs/source/overview/profiles_and_parameters.rst Outdated
Comment thread traffic_ops/traffic_ops_golang/server/servers.go Outdated
@rimashah25
Copy link
Copy Markdown
Contributor Author

rimashah25 commented Sep 29, 2022 •
edited
Loading

As Rawlin said, we can't just change what TO is querying for when it looks for Parameters or servers etc. That would break a lot of things on install, that would take a while to fix by hand through the API. In a database migration, though, it should be pretty simple to swap out the old names for the new ones.

Yeah, I have a commit to push the new migration files.

@rimashah25 rimashah25 force-pushed the refactor/rascal_to_tm branch from 0dfe20f to 882263a Compare October 11, 2022 17:08
ocket8888
ocket8888 reviewed Oct 11, 2022
View reviewed changes
Comment thread traffic_ops/app/db/migrations/2022100610190300_update_rascal_to_traffic_monitor.up.sql Outdated
@rimashah25 rimashah25 force-pushed the refactor/rascal_to_tm branch from 882263a to d94dbd2 Compare October 27, 2022 06:01
ocket8888
ocket8888 suggested changes Oct 31, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the following references to RASCAL can be removed from the documentation

./docs/source/overview/profiles_and_parameters.rst:	.. warning:: For legacy reasons, the names of Profiles of this type *must* begin with ``RASCAL_``. This is **not** enforced by the :ref:`to-api` or Traffic Portal, but certain Traffic Control operations/components expect this and will fail to work otherwise!
./docs/source/admin/traffic_monitor.rst:	.. note:: For legacy compatibility reasons, the 'Type' field of a new Traffic Monitor server must be 'RASCAL'.

@rimashah25 rimashah25 requested a review from ocket8888 November 1, 2022 15:40
@ocket8888 ocket8888 merged commit d669a32 into apache:master Nov 1, 2022
@rimashah25 rimashah25 deleted the refactor/rascal_to_tm branch November 2, 2022 15:08
This was referenced Nov 14, 2022
Merged
Merged
rimashah25 added a commit to rimashah25/trafficcontrol that referenced this pull request Nov 16, 2022
@rimashah25
Revert commits apache#7068, apache#7172, apache#7175
9e9bec1
ocket8888 pushed a commit that referenced this pull request Nov 16, 2022
@rimashah25
Revert Traffic Monitor renaming to rascal (#7190)
02b9f04 
* Revert "Dev CiaB: Prefix Traffic Monitor profile name with TM profile prefix (#7175)"

This reverts commit 3721d91.

* Revert "Renamed rascal migration file to get latest time stamp (#7172)"

This reverts commit f956d76.

* Revert commits #7068, #7172, #7175
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rawlinp rawlinp Awaiting requested review from rawlinp

1 more reviewer

@ocket8888 ocket8888 ocket8888 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ocket8888 ocket8888

Labels

cache-config Cache config generation documentation related to documentation tc-health-client Traffic Control Health Client Traffic Monitor related to Traffic Monitor Traffic Ops related to Traffic Ops

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Legacy Naming Conventions (Rascal, RIAK, CCR et. al.)

3 participants

@rimashah25 @ocket8888 @rawlinp