Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Traffic Router tests GHA: Include integration tests#7100

Merged
ocket8888 merged 8 commits intoapache:masterfrom
zrhoffman:tr-int-tests-gha
Oct 5, 2022
Merged

Traffic Router tests GHA: Include integration tests#7100
ocket8888 merged 8 commits intoapache:masterfrom
zrhoffman:tr-int-tests-gha

Conversation

@zrhoffman
Copy link
Copy Markdown
Member

This Pull Request

  • renames the Traffic Router Unit Tests workflow to Traffic Router Tests
  • Makes the Traffic Router Tests GitHub Action run the integration (and external) tests, in addition to the unit tests
  • Adds specific paths to the Experimental Traffic Portal v2 workflow's push trigger so it no longer runs on every commit

Which Traffic Control components are affected by this PR?

  • Automation - GitHub Actions

What is the best way to verify this PR?

Verify that the Traffic Router Tests GHA includes the TR integration tests

PR submission checklist

Copy link
Copy Markdown
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's having some kind of permissions issue uploading the JUnit reports

image

You can see this warning and error as annotations in the check run, even though it was successful (which makes sense because the actual tests themselves pass).

@ocket8888 ocket8888 added Traffic Router related to Traffic Router low impact affects only a small portion of a CDN, and cannot itself break one tests related to tests and/or testing infrastructure automation related to automated testing/deployment/packaging etc. labels Sep 30, 2022
@ocket8888 ocket8888 changed the title Traffic Router tests GHA: Inclue integration tests Traffic Router tests GHA: Include integration tests Sep 30, 2022
@ocket8888
Copy link
Copy Markdown
Contributor

I'm still seeing the same annotations in the latest run on that JUnit-to-annotation conversion.

Also it's not caching Maven dependencies because it can't find the directory at the end of the run:

Warning: Path Validation Error: Path(s) specified in the action for caching do(es) not exist, hence no cache is being saved.

@zrhoffman
Copy link
Copy Markdown
Member Author

I'm still seeing the same annotations in the latest run on that JUnit-to-annotation conversion.

I think that that is because the mikepenz/action-junit-report action is being used in a PR without being in the target branch. See the annotations resulting from the Build and run tests / Execute integration tests (11) workflow run on apache/unomi#512, since they already use mikepenz/action-junit-report.

They don't seem to be using it in any special way, either.

@zrhoffman
Copy link
Copy Markdown
Member Author

Also it's not caching Maven dependencies because it can't find the directory at the end of the run:

Warning: Path Validation Error: Path(s) specified in the action for caching do(es) not exist, hence no cache is being saved.

Fixed in 077d530

@ocket8888
Copy link
Copy Markdown
Contributor

Well if we can't get annotations on PRs, why have the step for converting JUnit to annotations?

@zrhoffman
Copy link
Copy Markdown
Member Author

But we can get annotations on PRs. See the annotations generated from the PR I linked above: https://github.com/apache/unomi/actions/runs/3129456290

@ocket8888
Copy link
Copy Markdown
Contributor

So you're saying that once this is merged it'll add annotations?

Lemme check that out. Or, well, at least check if the warning and error go away.

@zrhoffman
Copy link
Copy Markdown
Member Author

zrhoffman commented Sep 30, 2022

Switched back to the old action we were using that echoes annotations instead of using the API (I wish more of them did that) in 7483eaa

@zrhoffman zrhoffman requested a review from ocket8888 October 4, 2022 20:21
@ocket8888 ocket8888 merged commit 7995ce5 into apache:master Oct 5, 2022
zrhoffman added a commit to zrhoffman/trafficcontrol that referenced this pull request Nov 2, 2022
* Use well-known JUnit-to-annotations GitHub Action

* Run Traffic Router unit tests directly from the GHA runner

* Remove unused GitHub Action tr-unit-tests

* Run integration tests too

* Set traffic_router_rpm dummy environment variables

* Only run TPv2 tests workflow when TPV2 tests-related paths are modified

* Use default maven repository path

* Revert "Use well-known JUnit-to-annotations GitHub Action"

This reverts commit 52acba6.
@zrhoffman zrhoffman mentioned this pull request Jul 13, 2023
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automation related to automated testing/deployment/packaging etc. low impact affects only a small portion of a CDN, and cannot itself break one tests related to tests and/or testing infrastructure Traffic Router related to Traffic Router

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants