Traffic Router tests GHA: Include integration tests#7100
Traffic Router tests GHA: Include integration tests#7100ocket8888 merged 8 commits intoapache:masterfrom
Conversation
|
I'm still seeing the same annotations in the latest run on that JUnit-to-annotation conversion. Also it's not caching Maven dependencies because it can't find the directory at the end of the run:
|
3c7a4bf to
fb5f81b
Compare
I think that that is because the mikepenz/action-junit-report action is being used in a PR without being in the target branch. See the annotations resulting from the Build and run tests / Execute integration tests (11) workflow run on apache/unomi#512, since they already use mikepenz/action-junit-report. They don't seem to be using it in any special way, either. |
Fixed in 077d530 |
|
Well if we can't get annotations on PRs, why have the step for converting JUnit to annotations? |
|
But we can get annotations on PRs. See the annotations generated from the PR I linked above: https://github.com/apache/unomi/actions/runs/3129456290 |
|
So you're saying that once this is merged it'll add annotations? Lemme check that out. Or, well, at least check if the warning and error go away. |
This reverts commit 52acba6.
|
Switched back to the old action we were using that echoes annotations instead of using the API (I wish more of them did that) in 7483eaa |
* Use well-known JUnit-to-annotations GitHub Action * Run Traffic Router unit tests directly from the GHA runner * Remove unused GitHub Action tr-unit-tests * Run integration tests too * Set traffic_router_rpm dummy environment variables * Only run TPv2 tests workflow when TPV2 tests-related paths are modified * Use default maven repository path * Revert "Use well-known JUnit-to-annotations GitHub Action" This reverts commit 52acba6.

This Pull Request
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Verify that the Traffic Router Tests GHA includes the TR integration tests
PR submission checklist