Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Remove ASN from servers#7118

Merged
ocket8888 merged 4 commits intoapache:masterfrom
srijeet0406:remove_asn_from_servers
Oct 20, 2022
Merged

Remove ASN from servers#7118
ocket8888 merged 4 commits intoapache:masterfrom
srijeet0406:remove_asn_from_servers

Conversation

@srijeet0406
Copy link
Copy Markdown
Contributor

@srijeet0406 srijeet0406 commented Oct 11, 2022

This PR is not related to any issue. It removes the previously added (in #7023) asns field from the server struct.


Which Traffic Control components are affected by this PR?

  • Documentation
  • Traffic Control Client
  • Traffic Ops
  • Traffic Portal
  • CDN in a Box

What is the best way to verify this PR?

Make sure you don't see the asns field in GET calls that return the server object.
Make sure all tests pass.

If this is a bugfix, which Traffic Control versions contained the bug?

  • master

PR submission checklist

@srijeet0406 srijeet0406 added Traffic Ops related to Traffic Ops Traffic Portal v1 related to Traffic Portal version 1 documentation related to documentation unused code Code that can be removed due to no longer being used labels Oct 11, 2022
Comment thread traffic_ops/traffic_ops_golang/deliveryservice/keys_test.go Outdated
@ocket8888 ocket8888 added the low impact affects only a small portion of a CDN, and cannot itself break one label Oct 11, 2022
@ocket8888 ocket8888 self-assigned this Oct 11, 2022
@ocket8888 ocket8888 self-requested a review October 20, 2022 16:59
Copy link
Copy Markdown
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed ASN from every server representation I can think of

@ocket8888 ocket8888 merged commit bd6f7ee into apache:master Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation related to documentation low impact affects only a small portion of a CDN, and cannot itself break one Traffic Ops related to Traffic Ops Traffic Portal v1 related to Traffic Portal version 1 unused code Code that can be removed due to no longer being used

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants