This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Do not include non-TR profile params in CRConfig "config" section#7124
Merged
ocket8888 merged 1 commit intoapache:masterfrom Oct 13, 2022
Merged
Do not include non-TR profile params in CRConfig "config" section#7124ocket8888 merged 1 commit intoapache:masterfrom
ocket8888 merged 1 commit intoapache:masterfrom
Conversation
Instead of querying all profile parameters with the config file "CRConfig.json" for any servers of any type that belong to a given CDN, query only profile params assigned to profiles of CCR-type servers for the given CDN. Fixes apache#3974.
rawlinp
added
Traffic Ops
Contributor
|
Do you think there's any chance anyone is relying on that behavior? |
Contributor
Author
|
I think it would be highly unlikely. |
Contributor
|
What about the "GLOBAL" Profile that usually exists - does that have things that need to go in there? In CiaB its type is |
Contributor
Author
|
I don't think so, because the original query would only get params from profiles that are assigned to servers in the given CDN, which excludes the GLOBAL profile. |
ocket8888
added
the
low impact
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of querying all profile parameters with the config file "CRConfig.json" for any servers of any type that belong to a given CDN, query only profile params assigned to profiles of CCR-type servers for the given CDN.
Fixes #3974.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
ATS profiles will generally have a "weight" parameter assigned (with config_file = CRConfig.json), and this will tend to show up in the CRConfig "config" section like so:
With this PR, snapshotting that CDN should remove that "weight" parameter from the CRConfig's "config" section.
PR submission checklist