Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Add the ability to traffic Router to customize default https cert#7135

Merged
zrhoffman merged 7 commits intoapache:masterfrom
srijeet0406:customize_https_attributes
Oct 14, 2022
Merged

Add the ability to traffic Router to customize default https cert#7135
zrhoffman merged 7 commits intoapache:masterfrom
srijeet0406:customize_https_attributes

Conversation

@srijeet0406
Copy link
Copy Markdown
Contributor

This PR closes #7089
This PR adds the ability to provide customized attributes to the HTTPS default certificate.


Which Traffic Control components are affected by this PR?

  • Documentation
  • Traffic Router

What is the best way to verify this PR?

Make sure all the tests pass.
Try putting in different values for the properties in the https.properties file and make sure that the resulting default cert shows the right attributes.

If this is a bugfix, which Traffic Control versions contained the bug?

  • master

PR submission checklist

@srijeet0406 srijeet0406 added Traffic Router related to Traffic Router improvement The functionality exists but it could be improved in some way. labels Oct 13, 2022
@zrhoffman zrhoffman self-requested a review October 13, 2022 21:44
@zrhoffman
Copy link
Copy Markdown
Member

zrhoffman commented Oct 13, 2022

From the logs, there is a PMD error:

2022-10-13T22:00:23.5876488Z [�[1;34mINFO�[m] PMD Failure: org.apache.traffic_control.traffic_router.secure.CertificateRegistry:155 Rule:AvoidPrintStackTrace Priority:3 Avoid printStackTrace(); use a logger call instead..
```</strike>

Copy link
Copy Markdown
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, this all seems like an objective improvement!

@zrhoffman zrhoffman merged commit 8fb776b into apache:master Oct 14, 2022
@asf-ci asf-ci mentioned this pull request Nov 1, 2022
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

improvement The functionality exists but it could be improved in some way. Traffic Router related to Traffic Router

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Traffic Router default certificate configuration for port 443

2 participants