This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Traffic Vault: Fix reencrypt utility to uniquely reencrypt ssl keys#7159
Merged
ocket8888 merged 2 commits intoapache:masterfrom Oct 25, 2022
Merged
Traffic Vault: Fix reencrypt utility to uniquely reencrypt ssl keys#7159ocket8888 merged 2 commits intoapache:masterfrom
reencrypt utility to uniquely reencrypt ssl keys#7159ocket8888 merged 2 commits intoapache:masterfrom
Conversation
added 2 commits
October 25, 2022 14:14
ocket8888
approved these changes
Oct 25, 2022
Contributor
ocket8888
left a comment
There was a problem hiding this comment.
Appears to fix the bug
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #7158
A Traffic Vault utility called
reencryptallows for the ability to take previously encrypted values in the Traffic Vault DB and apply a new AES key for encryption. However, there was a bug that resulted in the "last" ssl key (misnomer) pulled from the DB during encryption would overwrite and wipe all other versions of ssl keys. This PR addresses said bug.Which Traffic Control components are affected by this PR?
reencrypt)What is the best way to verify this PR?
Previously existing "tests" should continue to work.
Manually verify:
reencryptutility with the necessary connection info specified in thereencrypt.conffile, along with passing in the file path locations for the previous AES key as well as the new AES key.If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist