Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

ATC build system: aarch64 support#7176

Merged
ocket8888 merged 3 commits intoapache:masterfrom
zrhoffman:rpm-for-arch
Nov 8, 2022
Merged

ATC build system: aarch64 support#7176
ocket8888 merged 3 commits intoapache:masterfrom
zrhoffman:rpm-for-arch

Conversation

@zrhoffman
Copy link
Copy Markdown
Member

This PR

  • Replaces cases where the build architecture is hard-coded as x86_64 with code that checks what the CPU architecture is
  • Replaces build code using uname -a with rpm --eval %_arch. This is especially useful for M1 macs, where uname -a returns arm64 but rpm --eval %_arch returns aarch64 (which is correct for RPMs).
  • Makes Traffic Router noarch architecture, since it's compiled to JVM bytecode

Which Traffic Control components are affected by this PR?

  • CDN in a Box
  • T3C integration tests ATS RPM builder
  • ATC Build system - Traffic Control Cache Config (t3c, formerly ORT), Traffic Control Health Client (tc-health-client), Traffic Monitor, Traffic Ops, Traffic Portal, Traffic Router, Traffic Stats, Grove, and Grove TC Config
    • Traffic Control Cache Config (t3c, formerly ORT)
    • Traffic Control Health Client (tc-health-client)
    • Traffic Monitor
    • Traffic Ops
    • Traffic Portal
    • Traffic Router
    • Traffic Stats
    • Grove and Grove TC Config

What is the best way to verify this PR?

Verify the RPMs build for your architecture:

cd infrastructure/cdn-in-a-box
make

PR submission checklist

@zrhoffman zrhoffman added tech debt rework due to choosing easy/limited solution cdn-in-a-box related to the Docker-based CDN-in-a-Box system build related to the build process improvement The functionality exists but it could be improved in some way. CPU arch Relating to support for a specific CPU architecture labels Nov 7, 2022
@zrhoffman
Copy link
Copy Markdown
Member Author

Rebased so TR Ultimate Test Harness passes now that #7175 is merged

Copy link
Copy Markdown
Contributor

@ericholguin ericholguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to build on arm64 and get aarch64 rpms

@ocket8888 ocket8888 merged commit 7370d99 into apache:master Nov 8, 2022
@zrhoffman zrhoffman deleted the rpm-for-arch branch July 26, 2023 17:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

build related to the build process cdn-in-a-box related to the Docker-based CDN-in-a-Box system CPU arch Relating to support for a specific CPU architecture improvement The functionality exists but it could be improved in some way. tech debt rework due to choosing easy/limited solution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants