This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Revert setting PGPASSWORD for entire db/admin binary#7198
Merged
srijeet0406 merged 2 commits intoapache:masterfrom Nov 16, 2022
Merged
Revert setting PGPASSWORD for entire db/admin binary#7198srijeet0406 merged 2 commits intoapache:masterfrom
PGPASSWORD for entire db/admin binary#7198srijeet0406 merged 2 commits intoapache:masterfrom
Conversation
zrhoffman
added
regression bug
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts
25483428a5, a commit in #7142 that set thePGPASSWORDenvironment variable for the entiredb/admin, rather than only setting it for specificpsqlsubprocesses. This has the effect of no longer breaking the T3C Integration Tests GHA workflow.#7198 breaks Traffic Ops in CDN in a Box for Developers, so hopefully we can come up with a different solution that will work for both CDN in a Box for Developers and the T3C integration tests, like fixing #4954.
Which Traffic Control components are affected by this PR?
t3c, formerly ORT) - integration testsapp/dbWhat is the best way to verify this PR?
Verify the T3C Integration Tests GHA workflow passes
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist