This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Added description field to server capabilities#7213
Merged
ocket8888 merged 21 commits intoapache:masterfrom Dec 16, 2022
Merged
Added description field to server capabilities#7213ocket8888 merged 21 commits intoapache:masterfrom
ocket8888 merged 21 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7213 +/- ##
============================================
- Coverage 28.36% 28.23% -0.13%
Complexity 98 98
============================================
Files 617 617
Lines 69195 69576 +381
Branches 90 90
============================================
+ Hits 19624 19642 +18
- Misses 47760 48120 +360
- Partials 1811 1814 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ocket8888
reviewed
Nov 22, 2022
ocket8888
added
Traffic Ops
rimashah25
force-pushed
the
feature/add-description-to-sc
branch
from
b077677 to
6c769a9
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rimashah25
force-pushed
the
feature/add-description-to-sc
branch
from
14c21f2 to
8c3f692
Compare
ocket8888
suggested changes
Dec 8, 2022
Contributor
ocket8888
left a comment
ocket8888
left a comment
There was a problem hiding this comment.
In 4.0 the response when there are no (matching) server capabilities was (properly) an empty collection. In 4.1 it is now null:
$ toget -kpa 4.0 'server_capabilities?name=quest'
{
"response": []
}
$ toget -kpa 4.1 'server_capabilities?name=quest'
{
"response": null
}
rimashah25
force-pushed
the
feature/add-description-to-sc
branch
from
95b75a2 to
140c0c3
Compare
ocket8888
reviewed
Dec 13, 2022
rimashah25
force-pushed
the
feature/add-description-to-sc
branch
from
8f60469 to
5466df4
Compare
rimashah25
force-pushed
the
feature/add-description-to-sc
branch
from
f432c5c to
51b4b5c
Compare
ocket8888
reviewed
Dec 15, 2022
ocket8888
reviewed
Dec 16, 2022
ocket8888
approved these changes
Dec 16, 2022
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #6234
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Use TP and curl cmds to perform all CRUD operations for server capability with and without
descriptionfield.Descriptionfield is optional.If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist