This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix unable to create DSRs for updating existing DSs#7217
Merged
zrhoffman merged 2 commits intoapache:masterfrom Nov 28, 2022
Merged
Fix unable to create DSRs for updating existing DSs#7217zrhoffman merged 2 commits intoapache:masterfrom
zrhoffman merged 2 commits intoapache:masterfrom
Conversation
That possibly also affected Delete-type requests, didn't check; the resolution would have been the same.
Codecov Report
@@ Coverage Diff @@
## master #7217 +/- ##
=======================================
Coverage 69.71% 69.71%
=======================================
Files 167 167
Lines 5647 5647
=======================================
Hits 3937 3937
Misses 1461 1461
Partials 249 249
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
a0ca22f to
6429969
Compare
6429969 to
3225da2
Compare
zrhoffman
approved these changes
Nov 28, 2022
Member
zrhoffman
left a comment
There was a problem hiding this comment.
I can create a Delivery Service Request now!
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7212
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Make sure the tests pass. To test manually, just make a DSR for updating an existing DS in APIv4
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist