Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Fix unable to create DSRs for updating existing DSs#7217

Merged
zrhoffman merged 2 commits intoapache:masterfrom
ocket8888:to/dsrs-fix
Nov 28, 2022
Merged

Fix unable to create DSRs for updating existing DSs#7217
zrhoffman merged 2 commits intoapache:masterfrom
ocket8888:to/dsrs-fix

Conversation

@ocket8888
Copy link
Copy Markdown
Contributor

Fixes #7212


Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Make sure the tests pass. To test manually, just make a DSR for updating an existing DS in APIv4

If this is a bugfix, which Traffic Control versions contained the bug?

  • master

PR submission checklist

  • This PR has tests
  • This PR needs no documentation
  • This PR needs no CHANGELOG.md entry
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

That possibly also affected Delete-type requests, didn't check; the
resolution would have been the same.
@ocket8888 ocket8888 added Traffic Ops related to Traffic Ops regression bug a bug in existing functionality introduced by a new version labels Nov 23, 2022
@ocket8888 ocket8888 changed the title Fix unable to create DSRs for updating existing DSRs Fix unable to create DSRs for updating existing DSs Nov 23, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 23, 2022

Codecov Report

Merging #7217 (3225da2) into master (e82501c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7217   +/-   ##
=======================================
  Coverage   69.71%   69.71%           
=======================================
  Files         167      167           
  Lines        5647     5647           
=======================================
  Hits         3937     3937           
  Misses       1461     1461           
  Partials      249      249           
Flag Coverage Δ
traffic_ops_integration 69.71% <ø> (ø)
v3 57.68% <ø> (ø)
v4 79.65% <ø> (ø)
v5 79.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ocket8888 ocket8888 force-pushed the to/dsrs-fix branch 2 times, most recently from a0ca22f to 6429969 Compare November 23, 2022 18:35
Copy link
Copy Markdown
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can create a Delivery Service Request now!

@zrhoffman zrhoffman merged commit ef9aa6d into apache:master Nov 28, 2022
@ocket8888 ocket8888 deleted the to/dsrs-fix branch November 28, 2022 16:55
@asf-ci asf-ci mentioned this pull request Dec 1, 2022
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

regression bug a bug in existing functionality introduced by a new version Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Creating a DSR: cannot update non-existent Delivery Service ''

2 participants