This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Tpv2 snapshot diff page#7220
Open
ocket8888 wants to merge 12 commits intoapache:masterfrom
Open
Conversation
ocket8888
added
new feature
ocket8888
force-pushed
the
tpv2/snapshot-diff-page
branch
from
bd484c5 to
7f6afab
Compare
4 tasks
also updated the CDN service to use trafficops-types typings
In particular, they can find the differences between generic mappings, Traffic Routers, and cache servers.
ocket8888
force-pushed
the
tpv2/snapshot-diff-page
branch
from
7f6afab to
293d793
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a page for showing snapshot diffs to TPv2. It's not complete, only shows diffs for the
contentServers,contentRouters, andconfigsections so far. Getting the rest done will be a bit of work, so I wanna get feedback on how I'm approaching this before going any further.Note that this addresses the concerns that led to the creation of #7113. I can't really say I "fixed" it, since it wasn't an issue in TPv2 just because of a lack of that functionality.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
The diffing utility functions are covered pretty extensively by
ng test, but what I'm really interested in is how you feel about using the actual UI.PR submission checklist