Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Use strings for JSONB string comparisons#7223

Merged
srijeet0406 merged 2 commits intoapache:masterfrom
zrhoffman:jsonb-string-comparisons
Nov 28, 2022
Merged

Use strings for JSONB string comparisons#7223
srijeet0406 merged 2 commits intoapache:masterfrom
zrhoffman:jsonb-string-comparisons

Conversation

@zrhoffman
Copy link
Copy Markdown
Member

@zrhoffman zrhoffman commented Nov 28, 2022

This PR fixes #7222 by using string comparisons in the migrations


Which Traffic Control components are affected by this PR?

  • Traffic Ops - database migrations

What is the best way to verify this PR?

Try to reproduce #7222

If this is a bugfix, which Traffic Control versions contained the bug?

PR submission checklist

@zrhoffman zrhoffman added bug something isn't working as intended Traffic Ops related to Traffic Ops database relating to setup/installation/structure of the Traffic Ops database labels Nov 28, 2022
Copy link
Copy Markdown
Contributor

@srijeet0406 srijeet0406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual and automated tests pass after the migration fixes. LGTM

@srijeet0406 srijeet0406 merged commit dda86f4 into apache:master Nov 28, 2022
@zrhoffman zrhoffman deleted the jsonb-string-comparisons branch November 28, 2022 23:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug something isn't working as intended database relating to setup/installation/structure of the Traffic Ops database Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TO DB migrations: cannot cast jsonb string to type boolean

3 participants