This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix issue 6533#7234
Merged
zrhoffman merged 5 commits intoapache:masterfrom Dec 6, 2022
villajo:fix_issue_6533
Merged
Conversation
added 4 commits
November 14, 2022 14:53
Added new file for log4j2.xml as well as logrotate configuration. We may need to tweak further, maybe add an hourly logrotate file if we feel like. But this is a good start. I need to know the other places that I need to modify Traffic Router to make sure the changes get into the RPM.
Addition of logrotate. Still need to test.
ocket8888
added
Traffic Router
zrhoffman
approved these changes
Dec 6, 2022
Member
zrhoffman
left a comment
zrhoffman
left a comment
There was a problem hiding this comment.
Looks great, thanks for your PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #6533
This ticket fixes an issue with logrotation in Traffic Router where the file handle wouldn't stay with the file being written to upon rotation. This would cause forwarding applications EG: Splunk or propriatory)
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Install Traffic-Router on a Rocky8 or CentOS7 system. In /etc/cron.daily, you'll see a file called logrotate. There will be a command that can be ran.. /usr/sbin/logrotate /etc/logrotate.conf. Running this will run the logrotate file for traffic router ( /etc/logrotate.d/traffic_router).
If this is a bugfix, which Traffic Control versions contained the bug?
All
PR submission checklist