Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Fix Internal Server Error when GETting sslkey_expirations endpoint#7294

Merged
ocket8888 merged 3 commits intoapache:masterfrom
srijeet0406:fix_ISE_sslkeys_expiration
Jan 20, 2023
Merged

Fix Internal Server Error when GETting sslkey_expirations endpoint#7294
ocket8888 merged 3 commits intoapache:masterfrom
srijeet0406:fix_ISE_sslkeys_expiration

Conversation

@srijeet0406
Copy link
Copy Markdown
Contributor

@srijeet0406 srijeet0406 commented Jan 17, 2023

This PR closes #7293


Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Hit the sslkeys_expirations endpoint and make sure you see the expected result without errors.

If this is a bugfix, which Traffic Control versions contained the bug?

  • master

PR submission checklist

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 17, 2023

Codecov Report

Merging #7294 (0cb99be) into master (1c5607c) will decrease coverage by 2.18%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #7294      +/-   ##
============================================
- Coverage     28.29%   26.11%   -2.18%     
  Complexity       98       98              
============================================
  Files           617      648      +31     
  Lines         69652    76057    +6405     
  Branches         90       90              
============================================
+ Hits          19705    19862     +157     
- Misses        48127    54362    +6235     
- Partials       1820     1833      +13     
Flag Coverage Δ
golib_unit 53.02% <ø> (-0.08%) ⬇️
grove_unit 4.60% <ø> (ø)
t3c_unit 5.32% <ø> (?)
traffic_monitor_unit 20.43% <ø> (ø)
traffic_ops_integration 69.34% <ø> (+0.05%) ⬆️
traffic_ops_unit 19.67% <0.00%> (-0.01%) ⬇️
traffic_stats_unit 10.41% <ø> (ø)
unit_tests 22.54% <0.00%> (?)
v3 57.79% <ø> (+0.11%) ⬆️
v4 79.09% <ø> (ø)
v5 78.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._golang/trafficvault/backends/postgres/postgres.go 0.47% <0.00%> (ø)
lib/go-tc/deliveryservice_requests.go 40.86% <0.00%> (ø)
...fic_ops_golang/deliveryservice/request/requests.go 0.00% <0.00%> (ø)
...fic_ops_golang/deliveryservice/request/validate.go 0.00% <0.00%> (ø)
lib/go-tc/copy.go
cache-config/t3c-apply/util/gitutil.go 0.00% <0.00%> (ø)
cache-config/t3c/t3c.go 0.00% <0.00%> (ø)
cache-config/t3cutil/actionlog.go 0.00% <0.00%> (ø)
cache-config/t3cutil/toreq/clientfuncs.go 0.00% <0.00%> (ø)
cache-config/t3c-tail/t3c-tail.go 0.00% <0.00%> (ø)
... and 31 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@srijeet0406 srijeet0406 requested a review from ocket8888 January 17, 2023 23:36
@ocket8888 ocket8888 added bug something isn't working as intended Traffic Ops related to Traffic Ops SSL support for/problems with SSL features medium impact impacts a significant portion of a CDN, or has the potential to do so labels Jan 18, 2023
Comment thread traffic_ops/traffic_ops_golang/trafficvault/backends/postgres/postgres.go Outdated
Comment thread CHANGELOG.md Outdated
@ocket8888 ocket8888 changed the title Fix Internal Server Error when GETting sslkeys_expirations endpoint Fix Internal Server Error when GETting sslkey_expirations endpoint Jan 19, 2023
@ocket8888 ocket8888 changed the title Fix Internal Server Error when GETting sslkey_expirations endpoint Fix Internal Server Error when GETting sslkey_expirations endpoint Jan 19, 2023
@ocket8888
Copy link
Copy Markdown
Contributor

Other than the Changelog, this looks good to go. Tested it and it's working.

@ocket8888 ocket8888 self-assigned this Jan 19, 2023
@ocket8888 ocket8888 merged commit 0a30f45 into apache:master Jan 20, 2023
@asf-ci asf-ci mentioned this pull request Feb 1, 2023
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug something isn't working as intended medium impact impacts a significant portion of a CDN, or has the potential to do so SSL support for/problems with SSL features Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Internal Server Error: GET /api/4.1/sslkey_expirations

2 participants