Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Add capability to Delivery Service (HTTP, DNS)#7314

Merged
ocket8888 merged 11 commits intoapache:masterfrom
rimashah25:feature/tp-add-sc-to-ds
Jan 31, 2023
Merged

Add capability to Delivery Service (HTTP, DNS)#7314
ocket8888 merged 11 commits intoapache:masterfrom
rimashah25:feature/tp-add-sc-to-ds

Conversation

@rimashah25
Copy link
Copy Markdown
Contributor

@rimashah25 rimashah25 commented Jan 25, 2023

Adds capability feature on a delivery service form.

Related: #7224


Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

  1. Create a Delivery Service (HTTP, DNS) and see a new field called Required Capability. This field should display existing capabilities.
  2. You should no longer be able to see Manage Required Capabilities in drop down menu on a DS form.
  3. When checking Delivery Service Request, you should now see the current value as an array.

Note: A checkbox is checked incase existing DS had the capability(ies) assigned to it.

If this is a bugfix, which Traffic Control versions contained the bug?

PR submission checklist

@rimashah25 rimashah25 force-pushed the feature/tp-add-sc-to-ds branch from b40f373 to 7c61559 Compare January 25, 2023 23:58
@rimashah25 rimashah25 marked this pull request as ready for review January 26, 2023 16:58
@rimashah25 rimashah25 requested a review from ocket8888 January 26, 2023 16:58
@ocket8888 ocket8888 self-assigned this Jan 26, 2023
@ocket8888 ocket8888 added Traffic Portal v1 related to Traffic Portal version 1 low impact affects only a small portion of a CDN, and cannot itself break one improvement The functionality exists but it could be improved in some way. labels Jan 26, 2023
Copy link
Copy Markdown
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come this only adds capabilities to HTTP and DNS DSes? Why not also STEERING and ANY_MAP?

Comment thread traffic_portal/app/src/common/modules/form/_form.scss Outdated
Comment thread traffic_portal/app/src/common/modules/form/_form.scss Outdated
@rimashah25
Copy link
Copy Markdown
Contributor Author

Because neither of those (as of today) have Manage Required Capabilities under the More button.

@rimashah25 rimashah25 requested a review from ocket8888 January 30, 2023 17:37
@rimashah25 rimashah25 force-pushed the feature/tp-add-sc-to-ds branch 2 times, most recently from 406f2dc to b97055c Compare January 30, 2023 21:51
@rimashah25 rimashah25 force-pushed the feature/tp-add-sc-to-ds branch from b97055c to f4f9858 Compare January 31, 2023 20:39
@rimashah25 rimashah25 requested a review from ocket8888 January 31, 2023 22:36
@ocket8888 ocket8888 merged commit 6d378de into apache:master Jan 31, 2023
@rimashah25 rimashah25 deleted the feature/tp-add-sc-to-ds branch February 1, 2023 00:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

improvement The functionality exists but it could be improved in some way. low impact affects only a small portion of a CDN, and cannot itself break one Traffic Portal v1 related to Traffic Portal version 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants