This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix reserved consistentHashQueryParams entries causing internal server error instead of client error#7405
Merged
zrhoffman merged 3 commits intoapache:masterfrom Apr 5, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7405 +/- ##
============================================
- Coverage 27.12% 27.12% -0.01%
Complexity 98 98
============================================
Files 685 685
Lines 77414 77421 +7
Branches 90 90
============================================
- Hits 20999 20998 -1
- Misses 54423 54431 +8
Partials 1992 1992
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zrhoffman
suggested changes
Mar 29, 2023
73764c4 to
03197b7
Compare
zrhoffman
approved these changes
Apr 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #6385 by causing Traffic Ops to return the correct error code (400 Bad Request) and an alert describing what went wrong when a client attempts to create or modify a Delivery Service such that it would an entry in its Consistent Hashing Query string Parameters that is reserved for use by Traffic Router.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
If this is a bugfix, which Traffic Control versions contained the bug
PR submission checklist