This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Adding CDN lock check for invalidation jobs#7441
Merged
rimashah25 merged 2 commits intoapache:masterfrom Apr 12, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7441 +/- ##
============================================
- Coverage 29.22% 29.22% -0.01%
Complexity 98 98
============================================
Files 781 781
Lines 81527 81537 +10
Branches 779 779
============================================
Hits 23826 23826
- Misses 55653 55663 +10
Partials 2048 2048
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rimashah25
approved these changes
Apr 12, 2023
Contributor
rimashah25
left a comment
There was a problem hiding this comment.
Code changes LGTM
Tested on local: Hard Locked a CDN as an admin user, logged in as an ops user and tried invalidate content but the lock prevented to do so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is not related to any issue. It makes sure that is a user has a hard lock on a CDN, no other user can create invalidation jobs on that CDN.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run TO and TP.
As user A, hard lock a CDN
As user B, login and try to create an invalidation job on the same CDN
Make sure that the request fails
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist