This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Changing registration changelog to include username#7511
Merged
rimashah25 merged 5 commits intoapache:masterfrom May 12, 2023
Merged
Changing registration changelog to include username#7511rimashah25 merged 5 commits intoapache:masterfrom
rimashah25 merged 5 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7511 +/- ##
============================================
+ Coverage 27.60% 30.17% +2.57%
Complexity 98 98
============================================
Files 686 789 +103
Lines 77933 82299 +4366
Branches 90 815 +725
============================================
+ Hits 21513 24834 +3321
- Misses 54400 55386 +986
- Partials 2020 2079 +59
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 105 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ocket8888
added
bug
rimashah25
reviewed
May 12, 2023
Contributor
rimashah25
left a comment
rimashah25
left a comment
There was a problem hiding this comment.
Code changes LGTM. I tested it locally and now the change log messages show username as registration_random_alphanumeric_characters instead of email or empty
rimashah25
approved these changes
May 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is not related to any issue. It fixes the changelog entry to include the username instead of email twice, when a registration is sent to a user.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Send a user registration email on TO/ TP and make sure the corresponding changelog shows the correct username for the user, instead of email.
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist