Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Fixes alert message for POST and PUT invalidationjobs API #7517

Merged
ocket8888 merged 3 commits into from
May 25, 2023
Merged

Fixes alert message for POST and PUT invalidationjobs API #7517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41c97e5
Fixed alert message for POST and PUT invalidationjobs API
rimashah25 May 12, 2023
50e82dc
merge changelog
rimashah25 May 12, 2023
4e6eeef
Fixed error message.
rimashah25 May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- [#7469](https://github.com/apache/trafficcontrol/pull/7469) *Traffic Ops* Changed logic to not report empty or missing cookies into TO error.log.

### Fixed
- [#6340](https://github.com/apache/trafficcontrol/issues/6340) *Traffic Ops* Fixed alert messages for POST and PUT invalidation job APIs.
- [#7511](https://github.com/apache/trafficcontrol/pull/7511) *Traffic Ops* Fixed the changelog registration message to include the username instead of duplicate email entry.
- [#7465](https://github.com/apache/trafficcontrol/issues/7465) *Traffic Ops* Fixes server_capabilities v5 apis to respond with RFC3339 date/time Format
- [#7441](https://github.com/apache/trafficcontrol/pull/7441) *Traffic Ops* Fixed the invalidation jobs endpoint to respect CDN locks.
Expand Down
4 changes: 2 additions & 2 deletions traffic_ops/traffic_ops_golang/invalidationjobs/invalidationjobs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -958,7 +958,7 @@ func UpdateV40(w http.ResponseWriter, r *http.Request) {

if job.InvalidationType != input.InvalidationType {
if input.InvalidationType == tc.REFETCH && !refetchAllowed(inf.Tx.Tx) {
userErr = errors.New("Invalidation Type REFRESH is disallowed")
userErr = errors.New("Invalidation Type REFETCH is disallowed")
errCode = http.StatusBadRequest
api.HandleErr(w, r, inf.Tx.Tx, errCode, userErr, nil)
return
Expand Down Expand Up @@ -1455,7 +1455,7 @@ func validateJobCreateV4(job tc.InvalidationJobCreateV4, tx *sql.Tx) error {
}

if job.InvalidationType == tc.REFETCH && !refetchAllowed(tx) {
errs = append(errs, "InvalidationType is invalid")
errs = append(errs, "invalidationType is not allowed since 'refetch_enabled' parameter doesn't exists or the value is not set to a case-insensitive 'true'")
}

if len(errs) > 0 {
Expand Down