Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Fixes Delivery Service Requests V5 apis docs with RFC3339 date/time Format#7572

Merged
rimashah25 merged 7 commits intoapache:masterfrom
jagan-parthiban:improve/rfc3339-ds-requests
Jun 14, 2023
Merged

Fixes Delivery Service Requests V5 apis docs with RFC3339 date/time Format#7572
rimashah25 merged 7 commits intoapache:masterfrom
jagan-parthiban:improve/rfc3339-ds-requests

Conversation

@jagan-parthiban
Copy link
Copy Markdown
Contributor

@jagan-parthiban jagan-parthiban commented Jun 9, 2023 •
edited
Loading

Closes: #7571
Related: #5911

  • Documentation

What is the best way to verify this PR?

Documentation Changes only.

If this is a bugfix, which Traffic Control versions contained the bug?

  • 7.0.1

PR submission checklist

@jagan-parthiban jagan-parthiban changed the title Fixes Delivery Service Requests V5 apis to respond with RFC3339 date/time Forma Fixes Delivery Service Requests V5 apis docs with RFC3339 date/time Format Jun 9, 2023
@jagan-parthiban jagan-parthiban marked this pull request as ready for review June 13, 2023 02:29
rimashah25
rimashah25 suggested changes Jun 13, 2023
View reviewed changes
Comment thread docs/source/api/v5/deliveryservice_requests_id_assign.rst
Comment thread docs/source/api/v5/deliveryservice_requests.rst
Comment thread docs/source/api/v5/deliveryservice_requests.rst
Comment thread docs/source/api/v5/deliveryservice_requests_id_status.rst
rimashah25
rimashah25 suggested changes Jun 13, 2023
View reviewed changes
Comment thread docs/source/api/v5/deliveryservice_requests.rst
rimashah25
rimashah25 approved these changes Jun 13, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@rimashah25 rimashah25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

@rimashah25
Copy link
Copy Markdown
Contributor

rimashah25 commented Jun 13, 2023

I can merge once conflicts are resolved.

@ocket8888 ocket8888 added bug something isn't working as intended documentation related to documentation low impact affects only a small portion of a CDN, and cannot itself break one labels Jun 13, 2023
@jagan-parthiban jagan-parthiban force-pushed the improve/rfc3339-ds-requests branch from df67b80 to 1cba132 Compare June 14, 2023 02:15
@jagan-parthiban jagan-parthiban force-pushed the improve/rfc3339-ds-requests branch from 1cba132 to 8b8ced3 Compare June 14, 2023 02:18
@rimashah25 rimashah25 merged commit b57032a into apache:master Jun 14, 2023
@jagan-parthiban jagan-parthiban deleted the improve/rfc3339-ds-requests branch June 18, 2023 04:55
@asf-ci-trafficcontrol asf-ci-trafficcontrol mentioned this pull request Jul 1, 2023
Merged
4 tasks
@rimashah25 rimashah25 added this to the 8.0.0 milestone Jul 17, 2023
@asf-ci-trafficcontrol asf-ci-trafficcontrol mentioned this pull request Aug 1, 2023
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@rimashah25 rimashah25 rimashah25 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug something isn't working as intended documentation related to documentation low impact affects only a small portion of a CDN, and cannot itself break one

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

deliveryservice_requests in TO API uses non-RFC3339 date/time strings

3 participants

@jagan-parthiban @rimashah25 @ocket8888