This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Trim whitespace before comparing certificate chains#7628
Merged
srijeet0406 merged 2 commits intoapache:masterfrom Jul 10, 2023
Merged
Trim whitespace before comparing certificate chains#7628srijeet0406 merged 2 commits intoapache:masterfrom
srijeet0406 merged 2 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7628 +/- ##
=========================================
Coverage 30.12% 30.13%
Complexity 98 98
=========================================
Files 794 794
Lines 84072 84075 +3
Branches 907 907
=========================================
+ Hits 25329 25332 +3
+ Misses 56613 56612 -1
- Partials 2130 2131 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
srijeet0406
approved these changes
Jul 10, 2023
f6a1a56 to
c4a1143
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where SSL certificate chain validation fails if the chain does not end with a newline.
This PR also fixes an issue where TO would return a 500 ISE if certificate verification passes.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
If this is a bugfix, which Traffic Control versions contained the bug?
6.1.0
7.0.0
PR submission checklist