This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fixes Phys_Location V5 apis to respond with RFC3339 date/time Format#7631
Merged
srijeet0406 merged 9 commits intoapache:masterfrom Jul 21, 2023
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| query := selectQuery() + where + orderBy + pagination | ||
| rows, err := tx.NamedQuery(query, queryValues) |
Check failure
Code scanning / CodeQL
Database query built from user-controlled sources
jagan-parthiban
force-pushed
the
improve/rfc3339-phy-location
branch
from
d7b9add to
05a14bd
Compare
jagan-parthiban
added
Traffic Ops
Codecov Report
@@ Coverage Diff @@
## master #7631 +/- ##
============================================
- Coverage 32.34% 29.95% -2.39%
Complexity 98 98
============================================
Files 762 794 +32
Lines 77708 84575 +6867
Branches 907 905 -2
============================================
+ Hits 25137 25338 +201
- Misses 50455 57104 +6649
- Partials 2116 2133 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 43 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
srijeet0406
reviewed
Jul 11, 2023
Contributor
|
Also, looks like there's a conflict in changelog.md |
jagan-parthiban
force-pushed
the
improve/rfc3339-phy-location
branch
from
c77db30 to
09750e0
Compare
Contributor
Author
Resolved Merge Conflict. |
srijeet0406
reviewed
Jul 13, 2023
jagan-parthiban
force-pushed
the
improve/rfc3339-phy-location
branch
from
dff8d5e to
34ab843
Compare
srijeet0406
approved these changes
Jul 21, 2023
Contributor
srijeet0406
left a comment
srijeet0406
left a comment
There was a problem hiding this comment.
Looks great. Thanks for fixing this!
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #7630
Related: #5911
What is the best way to verify this PR?
Make Api calls to Phys_Location 5.0
Phys_Location to Use RFC3339 Format
{ "response": [ { "address": "Buckingham Palace", "city": "London", "comments": "Buckingham Palace", "email": "steve.kingstone@royal.gsx.gov.uk", "id": 41, "lastUpdated": "2023-07-09T18:56:27.057163+05:30", "name": "New_Scot", "phone": "0-843-816-6276", "poc": "Her Majesty The Queen Elizabeth Alexandra Mary Windsor II", "regionId": 71, "region": "Scotland", "shortName": "new_scot", "state": "Westminster", "zip": "SW1A 1AA" }, ] }If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist