Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Add HTTPS support to Varnish cache using Hitch#7725

Merged
limited merged 2 commits intoapache:masterfrom
AbdelrahmanElawady:add-hitch
Sep 5, 2023
Merged

Add HTTPS support to Varnish cache using Hitch#7725
limited merged 2 commits intoapache:masterfrom
AbdelrahmanElawady:add-hitch

Conversation

@AbdelrahmanElawady
Copy link
Copy Markdown
Member

Add HTTPS support to Varnish based CIAB instances using Hitch and configuring certificates using TO data.

Closes: #7722


Which Traffic Control components are affected by this PR?

  • Traffic Control Cache Config (t3c, formerly ORT)
  • CDN in a Box

What is the best way to verify this PR?

  • Run CIAB as mentioned in Add parents to varnish cache #7669 with Varnish as Edge (requests between cache servers are using HTTP. So, Edge will only verify this PR).
  • Try the readiness check by running docker-compose -f docker-compose.readiness.yml up
  • Or just run docker-compose exec enroller curl -L --insecure "https://video.demo1.mycdn.ciab.test"
  • It should serve the request with no problem.

PR submission checklist

@AbdelrahmanElawady AbdelrahmanElawady added new feature A new feature, capability or behavior low impact affects only a small portion of a CDN, and cannot itself break one cdn-in-a-box related to the Docker-based CDN-in-a-Box system cache-config Cache config generation low difficulty the estimated level of effort to resolve this issue is low Varnish related to Varnish labels Aug 16, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 25, 2023

Codecov Report

Merging #7725 (17fa8f1) into master (75ec56f) will decrease coverage by 36.13%.
Report is 102 commits behind head on master.
The diff coverage is 49.17%.

@@              Coverage Diff              @@
##             master    #7725       +/-   ##
=============================================
- Coverage     65.05%   28.92%   -36.13%     
  Complexity       98       98               
=============================================
  Files           314      596      +282     
  Lines         12365    76703    +64338     
  Branches        907       90      -817     
=============================================
+ Hits           8044    22190    +14146     
- Misses         3968    52435    +48467     
- Partials        353     2078     +1725     
Flag Coverage Δ
golib_unit 53.75% <60.68%> (?)
grove_unit 12.02% <ø> (?)
t3c_unit 5.96% <2.80%> (?)
traffic_monitor_unit 26.33% <0.00%> (?)
traffic_ops_unit 21.62% <ø> (?)
traffic_portal_v2 ?
traffic_stats_unit 10.78% <ø> (?)
unit_tests 25.73% <49.17%> (-48.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cache-config/t3c-apply/config/config.go 0.00% <0.00%> (ø)
cache-config/t3c-apply/torequest/cmd.go 0.00% <0.00%> (ø)
cache-config/t3c-check-refs/t3c-check-refs.go 1.78% <0.00%> (ø)
cache-config/t3c-generate/cfgfile/varnish.go 0.00% <0.00%> (ø)
cache-config/t3c-generate/config/config.go 0.81% <0.00%> (-0.08%) ⬇️
cache-config/t3c-generate/t3c-generate.go 0.00% <ø> (ø)
lib/go-atscfg/parentabstraction.go 80.00% <ø> (ø)
lib/go-tc/cdns.go 0.00% <ø> (ø)
lib/go-tc/deliveryservice_servers.go 0.00% <0.00%> (ø)
lib/go-tc/federation_resolver.go 45.45% <0.00%> (ø)
... and 19 more

... and 475 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zrhoffman zrhoffman removed the low difficulty the estimated level of effort to resolve this issue is low label Aug 25, 2023
@limited
Copy link
Copy Markdown
Contributor

limited commented Sep 1, 2023

I've looked at code, looks good so far. Still need to pull down and test

@limited limited merged commit c571cf3 into apache:master Sep 5, 2023
@AbdelrahmanElawady AbdelrahmanElawady deleted the add-hitch branch September 5, 2023 14:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cache-config Cache config generation cdn-in-a-box related to the Docker-based CDN-in-a-Box system low impact affects only a small portion of a CDN, and cannot itself break one new feature A new feature, capability or behavior Varnish related to Varnish

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add support for HTTPS requests to Varnish cache

3 participants