Add TM integration and separate docker-compose services for Varnish#7746
Conversation
|
marked draft until #7727 is reviewed |
009275d to
d024cb1
Compare
Codecov Report
@@ Coverage Diff @@
## master #7746 +/- ##
=============================================
- Coverage 65.05% 28.83% -36.22%
Complexity 98 98
=============================================
Files 314 598 +284
Lines 12365 77009 +64644
Branches 907 90 -817
=============================================
+ Hits 8044 22206 +14162
- Misses 3968 52720 +48752
- Partials 353 2083 +1730
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 476 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fdaa193 to
1d3a639
Compare
| checkInterval time.Duration | ||
| } | ||
|
|
||
| type vstats struct { |
There was a problem hiding this comment.
Can this struct be shared with anything that Traffic Monitor already deserializes?
There was a problem hiding this comment.
It definitely should be shared however it's implemented as just "main" package separated from TC so it's not a package that TM can call. However, I think it should be a package under TC and be built with pkg considering statistics will be added too. Should that be in this PR or done separately?
There was a problem hiding this comment.
If its ok with you, let's keep it separate, since this one is pretty well baked already
There was a problem hiding this comment.
Yep, will open an issue for it to be done later.
| } | ||
|
|
||
| infSpeedFile := fmt.Sprintf("/sys/class/net/%s/speed", inf) | ||
| speedStr, err := os.ReadFile(infSpeedFile) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
2fb179b to
e840378
Compare
Add Traffic Monitor integration with a daemon running on Varnish cache servers to report whether Varnish is running or not and to report load average and interface stats. Also, running Varnish now with CIAB is more user friendly and does not require changing any file manually just specifying varnish docker compose file with the default one.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
After building rpms needed for CIAB:
docker-compose -f docker-compose.yml -f docker-compose.varnish.yml upthat should run all cache servers with Varnish.docker-compose exec edge systemctl stop varnish.service.PR submission checklist