Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Changing Traffic Router to point to Traffic Ops api version 5.0#7757

Merged
zrhoffman merged 3 commits intoapache:masterfrom
srijeet0406:tr_to_api_5.0
Aug 29, 2023
Merged

Changing Traffic Router to point to Traffic Ops api version 5.0#7757
zrhoffman merged 3 commits intoapache:masterfrom
srijeet0406:tr_to_api_5.0

Conversation

@srijeet0406
Copy link
Copy Markdown
Contributor

@srijeet0406 srijeet0406 commented Aug 29, 2023

It changes Traffic Router to point to api 5.0 of Traffic Ops.
Closes: #7658


Which Traffic Control components are affected by this PR?

  • Traffic Router

What is the best way to verify this PR?

Make sure all the tests pass.
Make sure TR works as ecpected in an end to end scenario.

If this is a bugfix, which Traffic Control versions contained the bug?

  • 8.0.0

PR submission checklist

@srijeet0406 srijeet0406 added the Traffic Router related to Traffic Router label Aug 29, 2023
Copy link
Copy Markdown
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hard-coded API versions also need to be changed in the test CrConfigs

traffic_router/core/src/test/resources/publish/CrConfig.json
traffic_router/core/src/test/resources/publish/CrConfig2.json
traffic_router/core/src/test/resources/publish/CrConfig3.json
traffic_router/core/src/test/resources/publish/CrConfig4.json

@srijeet0406
Copy link
Copy Markdown
Contributor Author

The hard-coded API versions also need to be changed in the test CrConfigs

traffic_router/core/src/test/resources/publish/CrConfig.json traffic_router/core/src/test/resources/publish/CrConfig2.json traffic_router/core/src/test/resources/publish/CrConfig3.json traffic_router/core/src/test/resources/publish/CrConfig4.json

Yeah just noticed that. Fix has been pushed.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 29, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 31.91%. Comparing base (66e93a1) to head (9c19dc7).
⚠️ Report is 276 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #7757   +/-   ##
=========================================
  Coverage     31.91%   31.91%           
  Complexity       98       98           
=========================================
  Files           712      712           
  Lines         81875    81875           
  Branches        965      965           
=========================================
  Hits          26133    26133           
  Misses        53596    53596           
  Partials       2146     2146           
Flag Coverage Δ
traffic_router_unit ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@zrhoffman zrhoffman merged commit 3735399 into apache:master Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Traffic Router related to Traffic Router

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TR should default to using TO API 5.0

2 participants