This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fixed phys_locations update API to remove error related to mismatching region name and ID#7762
Merged
shamrickus merged 2 commits intoapache:masterfrom Aug 30, 2023
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7762 +/- ##
============================================
- Coverage 31.90% 31.88% -0.02%
Complexity 98 98
============================================
Files 712 712
Lines 81920 81907 -13
Branches 965 965
============================================
- Hits 26134 26114 -20
- Misses 53641 53642 +1
- Partials 2145 2151 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shamrickus
approved these changes
Aug 30, 2023
Member
shamrickus
left a comment
There was a problem hiding this comment.
LGTM
Added test case and bug is fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is not related to any issue. It fixes the case where a physical location could not be updated in api v5.0, due to a bug where regiona name and region ID do not match.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
If the user uses TP (with version 5) to update a PhysLoc's Region, the update will fail with the message "region name and ID do not match" before this PR. This error should be fixed with this change.
It can also be recreated by calling the endpoint and changing just the ID (and not the name). In this case the API should use the ID instead of name.
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist