Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Removing v5 client methods for Delivery Service Required Capabilities#7804

Merged
rimashah25 merged 3 commits intoapache:masterfrom
srijeet0406:remove_ds_reqd_capabilities
Sep 14, 2023
Merged

Removing v5 client methods for Delivery Service Required Capabilities#7804
rimashah25 merged 3 commits intoapache:masterfrom
srijeet0406:remove_ds_reqd_capabilities

Conversation

@srijeet0406
Copy link
Copy Markdown
Contributor

@srijeet0406 srijeet0406 commented Sep 13, 2023

This PR closes #7801
This PR removes unneeded client methods for Delivery Service Required Capabilities.


Which Traffic Control components are affected by this PR?

  • Documentation
  • Traffic Control Client Golang
  • Traffic Ops
  • CDN in a Box

What is the best way to verify this PR?

Make sure CDN in a box builds and functions as expected.
Make sure all the tests pass.

If this is a bugfix, which Traffic Control versions contained the bug?

  • master

PR submission checklist

@srijeet0406 srijeet0406 added bug something isn't working as intended Traffic Ops related to Traffic Ops cdn-in-a-box related to the Docker-based CDN-in-a-Box system labels Sep 13, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 13, 2023

Codecov Report

Merging #7804 (bf28c2e) into master (75ec56f) will decrease coverage by 36.20%.
Report is 139 commits behind head on master.
The diff coverage is 40.18%.

@@              Coverage Diff              @@
##             master    #7804       +/-   ##
=============================================
- Coverage     65.05%   28.85%   -36.20%     
  Complexity       98       98               
=============================================
  Files           314      600      +286     
  Lines         12365    77193    +64828     
  Branches        907       90      -817     
=============================================
+ Hits           8044    22275    +14231     
- Misses         3968    52833    +48865     
- Partials        353     2085     +1732     
Flag Coverage Δ
golib_unit 53.56% <54.37%> (?)
grove_unit 12.02% <ø> (?)
t3c_unit 5.80% <2.74%> (?)
traffic_monitor_unit 26.44% <ø> (?)
traffic_ops_integration 69.42% <ø> (+<0.01%) ⬆️
traffic_ops_unit 21.50% <ø> (?)
traffic_portal_v2 ?
traffic_stats_unit 10.78% <ø> (?)
unit_tests 25.64% <40.18%> (-48.14%) ⬇️
v3 57.79% <ø> (ø)
v4 79.18% <ø> (ø)
v5 78.58% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cache-config/t3c-apply/config/config.go 0.00% <0.00%> (ø)
cache-config/t3c-apply/torequest/cmd.go 0.00% <0.00%> (ø)
cache-config/t3c-check-refs/t3c-check-refs.go 1.78% <0.00%> (ø)
cache-config/t3c-generate/cfgfile/varnish.go 0.00% <0.00%> (ø)
cache-config/t3c-generate/config/config.go 0.81% <0.00%> (-0.08%) ⬇️
cache-config/t3c-generate/t3c-generate.go 0.00% <ø> (ø)
lib/go-atscfg/parentabstraction.go 79.47% <ø> (ø)
lib/go-tc/cdns.go 0.00% <ø> (ø)
lib/go-tc/deliveryservice_servers.go 0.00% <0.00%> (ø)
lib/go-tc/federation_resolver.go 45.45% <0.00%> (ø)
... and 13 more

... and 486 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Comment thread traffic_ops/testing/api/v5/withobjs_test.go Outdated
Copy link
Copy Markdown
Contributor

@rimashah25 rimashah25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rimashah25 rimashah25 merged commit 0068dd8 into apache:master Sep 14, 2023
rimashah25 pushed a commit to rimashah25/trafficcontrol that referenced this pull request Sep 18, 2023
…apache#7804)

* Removing v5 client methods for Delivery Service Required Capabilities

* add changelog

* remove commented out code
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug something isn't working as intended cdn-in-a-box related to the Docker-based CDN-in-a-Box system Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API v5 client.CreateDeliveryServicesRequiredCapability 404s

2 participants