This repository was archived by the owner on Nov 24, 2025. It is now read-only.
cdns/{{name}}/federations and cdns/{{name}}/federations/{{ID}} use RFC3339 timestamps#7806
Merged
rimashah25 merged 20 commits intoapache:masterfrom Sep 20, 2023
Merged
Conversation
ocket8888
added
Traffic Ops
Codecov Report
@@ Coverage Diff @@
## master #7806 +/- ##
============================================
+ Coverage 28.83% 31.86% +3.02%
Complexity 98 98
============================================
Files 600 717 +117
Lines 77175 82720 +5545
Branches 90 965 +875
============================================
+ Hits 22256 26356 +4100
- Misses 52832 54203 +1371
- Partials 2087 2161 +74
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 120 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zrhoffman
suggested changes
Sep 15, 2023
rimashah25
reviewed
Sep 15, 2023
rimashah25
approved these changes
Sep 18, 2023
Contributor
rimashah25
left a comment
rimashah25
left a comment
There was a problem hiding this comment.
Code changes LGTM. Need to test on local.
zrhoffman
approved these changes
Sep 19, 2023
Contributor
|
Need to add a TTL check like one sees on the UI. |
ocket8888
force-pushed
the
to/cdn-federations-rfc3339
branch
2 times, most recently
from
956b750 to
d5c4ebb
Compare
ocket8888
force-pushed
the
to/cdn-federations-rfc3339
branch
from
d5c4ebb to
e569f84
Compare
Contributor
|
Test look good. Approved. |
rimashah25
added a commit
to rimashah25/trafficcontrol
that referenced
this pull request
Dec 4, 2023
…pache#7718 (apache#49) * Updated TP field names based on TO changes from PRs apache#7806, apache#7718, * Updated TP field name (cdn) in server capability and updated changelog
rimashah25
added a commit
to rimashah25/trafficcontrol
that referenced
this pull request
Dec 4, 2023
…pache#7718 Updated TP field name (cdn) in server capability and updated changelog
rimashah25
added a commit
to rimashah25/trafficcontrol
that referenced
this pull request
Dec 4, 2023
…pache#7718 Updated TP field name (cdn) in server capability and updated changelog
zrhoffman
pushed a commit
that referenced
this pull request
Dec 4, 2023
* * Fixed broken capability links for DS * Updated CHANGELOG.md * Updated based on review comment as well as removed deleteServerCapability button(DS table) and menu-option(right click) * Updated TP field names based on TO changes from ATC PRs #7806, #7718 Updated TP field name (cdn) in server capability and updated changelog * Updated broken links in DS's right click menu
rimashah25
added a commit
that referenced
this pull request
Jan 3, 2024
Updated based on review comment as well as removed deleteServerCapability button(DS table) and menu-option(right click) Updated TP field names based on TO changes from ATC PRs #7806, #7718 Updated TP field name (cdn) in server capability and updated changelog Updated broken links in DS's right click menu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7799 and thereby closes #5911
This PR updates the "CDN Federations" endpoint(s) to use RFC3339 timestamps. Also, with the recent sphinx upgrade, our RFC text roles aren't working due to missing grave accents, so I fixed those.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Make sure all of the tests provided pass. I added a bunch of unit tests, too - not nearly 100% coverage, but better than nothing.
PR submission checklist