This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Update Go module version to v8#7814
Merged
rimashah25 merged 5 commits intoapache:masterfrom Sep 22, 2023
Merged
Conversation
git ls-files | grep -vE '^CHANGELOG|^vendor|\.go$' | xargs grep -lE '[^/]github\.com/apache/trafficcontrol/' | xargs sed -Ei 's|([^/]github\.com/apache/trafficcontrol/)|\1v8/|g'
git ls-files '**.go' | grep -vE ^vendor | xargs grep -lE '[^/]github\.com/apache/trafficcontrol/' | xargs sed -Ei 's|([^/]github\.com/apache/trafficcontrol/)|\1v8/|g'
Codecov Report
@@ Coverage Diff @@
## master #7814 +/- ##
=============================================
- Coverage 65.64% 31.83% -33.81%
Complexity 98 98
=============================================
Files 323 717 +394
Lines 12827 82718 +69891
Branches 965 965
=============================================
+ Hits 8420 26337 +17917
- Misses 4048 54216 +50168
- Partials 359 2165 +1806
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 293 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rimashah25
pushed a commit
that referenced
this pull request
Sep 22, 2023
* Use :atc-godoc: role instead of pkg.go.dev URLs * Update module path to v8 in non-golang files git ls-files | grep -vE '^CHANGELOG|^vendor|\.go$' | xargs grep -lE '[^/]github\.com/apache/trafficcontrol/' | xargs sed -Ei 's|([^/]github\.com/apache/trafficcontrol/)|\1v8/|g' * Update module path to v8 in golang sources git ls-files '**.go' | grep -vE ^vendor | xargs grep -lE '[^/]github\.com/apache/trafficcontrol/' | xargs sed -Ei 's|([^/]github\.com/apache/trafficcontrol/)|\1v8/|g' * Revert "Retract versions v1.1.0 through v1.1.5 from Go modules (#7150)" This reverts commit 83255a7. * Update module version to v8 (cherry picked from commit 0115c92)
jpappa200
pushed a commit
to jpappa200/trafficcontrol
that referenced
this pull request
Sep 27, 2023
* Use :atc-godoc: role instead of pkg.go.dev URLs * Update module path to v8 in non-golang files git ls-files | grep -vE '^CHANGELOG|^vendor|\.go$' | xargs grep -lE '[^/]github\.com/apache/trafficcontrol/' | xargs sed -Ei 's|([^/]github\.com/apache/trafficcontrol/)|\1v8/|g' * Update module path to v8 in golang sources git ls-files '**.go' | grep -vE ^vendor | xargs grep -lE '[^/]github\.com/apache/trafficcontrol/' | xargs sed -Ei 's|([^/]github\.com/apache/trafficcontrol/)|\1v8/|g' * Revert "Retract versions v1.1.0 through v1.1.5 from Go modules (apache#7150)" This reverts commit 83255a7. * Update module version to v8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #4380 and fixes #6304 by updating the ATC module path from
trafficcontrol/go.mod
Line 1 in 75c3769
to
trafficcontrol/go.mod
Line 1 in 1872785
and updates references to the latest ATC Go module around the repo to reference the
v8version. See the commit messages for the commands used to update files and #4380 (comment) for the motivation for this PR.Note that this PR does not move any files, because moving files is unnecessary to update the module version.
Once this PR is merged, a message will appear at the top of https://pkg.go.dev/github.com/apache/trafficcontrol like this:
because the latest module will be at https://pkg.go.dev/github.com/apache/trafficcontrol/v8.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Verify that the 8 non-URL, non-local-path instances of
github.com/apache/trafficcontrol/in the repo that did not havev8/appended to them. They should stay as-is:PR submission checklist