This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Bugfix/compare profile page#7885
Merged
srijeet0406 merged 3 commits intoapache:masterfrom Dec 19, 2023
Merged
Conversation
Fixed get profiles to return list of asscoaited parameters to a profile.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7885 +/- ##
============================================
+ Coverage 28.87% 31.81% +2.93%
Complexity 98 98
============================================
Files 602 719 +117
Lines 77355 82729 +5374
Branches 90 970 +880
============================================
+ Hits 22339 26319 +3980
- Misses 52925 54247 +1322
- Partials 2091 2163 +72
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mitchell852
reviewed
Dec 18, 2023
srijeet0406
reviewed
Dec 19, 2023
srijeet0406
approved these changes
Dec 19, 2023
Contributor
srijeet0406
left a comment
srijeet0406
left a comment
There was a problem hiding this comment.
LGTM, just waiting for the tp integration tests to pass.
rimashah25
added a commit
that referenced
this pull request
Jan 3, 2024
* Fixed Compare Profiles Page Issue Fixed get profiles to return list of asscoaited parameters to a profile. * Updated changelog * using a defined constant instead of hard coded value (cherry picked from commit 83556e8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compare Profile Page isn't working in TP. This PR fixes the same.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Login to TP, Click on Configure -> Profiles -> More -> Compare Profiles.
Select any two profiles and hit comapare.
Without this fix, the below page will not appear and the user is redirected to profile page (list of profiles in Table)
Wit this fix, the user will see the below page
If this is a bugfix, which Traffic Control versions contained the bug?
7.1.0
PR submission checklist