Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Expose TOMCAT_VERSION to Traffic Router tests docker compose service#8042

Merged
rimashah25 merged 1 commit intoapache:masterfrom
zrhoffman:tr-tomcat-version-docker-compose
Jul 9, 2024
Merged

Expose TOMCAT_VERSION to Traffic Router tests docker compose service#8042
rimashah25 merged 1 commit intoapache:masterfrom
zrhoffman:tr-tomcat-version-docker-compose

Conversation

@zrhoffman
Copy link
Copy Markdown
Member

This PR fixes the TR unit tests docker environment after #8040 broke it:

unit_router_1  | [ERROR] 'dependencies.dependency.version' for org.apache.tomcat:tomcat-coyote:jar must be a valid version but is '${env.TOMCAT_VERSION}'. @ line 88, column 13

Which Traffic Control components are affected by this PR?

  • Traffic Router - unit tests

What is the best way to verify this PR?

Verify that the test pass in docker:

docker compose -f traffic_router/tests/docker-compose.yml up

PR submission checklist

@zrhoffman zrhoffman added Traffic Router related to Traffic Router tests related to tests and/or testing infrastructure dependencies Pull requests that update a dependency file labels Jul 9, 2024
@zrhoffman zrhoffman changed the title Expose TOMCAT_VERSION to Traffic Router tests docker-compose service Expose TOMCAT_VERSION to Traffic Router tests docker compose service Jul 9, 2024
@zrhoffman zrhoffman force-pushed the tr-tomcat-version-docker-compose branch from 7947e42 to f5183c3 Compare July 9, 2024 05:22
Copy link
Copy Markdown
Contributor

@rimashah25 rimashah25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rimashah25 rimashah25 merged commit 1a80eb7 into apache:master Jul 9, 2024
@zrhoffman zrhoffman deleted the tr-tomcat-version-docker-compose branch July 9, 2024 15:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Pull requests that update a dependency file tests related to tests and/or testing infrastructure Traffic Router related to Traffic Router

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants