[openbsd] BaseLogFile.cc:244:61: error: invalid conversion from 'long int*' to 'time_t* {aka long long int*}' [-fpermissive]

[jirib]

Build fails on BaseLogFile.cc.

$ sysctl kern.version
kern.version=OpenBSD 6.0-current (GENERIC.MP) #117: Sat Jan  7 09:10:45 MST 2017
    build@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP

Making all in ts
gmake[3]: Entering directory '/home/jirib/openbsd/pobj/trafficserver-20170106/trafficserver-24347df553e91660b794af1079fbf69f986dc5b4/lib/ts'
depbase=`echo BaseLogFile.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
/usr/bin/libtool  --tag=CXX   --mode=compile c++ -DHAVE_CONFIG_H -I. -I../../lib  -I/home/jirib/openbsd/pobj/trafficserver-20170106/trafficserver-24347df553e91660b794af1079fbf69f986dc5b4/lib -I/usr/local/include
-Dopenbsd -D_LARGEFILE64_SOURCE=1 -D_COMPILE64BIT_SOURCE=1 -D_GNU_SOURCE -D_REENTRANT -D__STDC_LIMIT_MACROS=1 -D__STDC_FORMAT_MACROS=1 -D_FORTIFY_SOURCE=2 -I/usr/include -DOPENSSL_NO_SSL_INTERN -I/usr/local/include/tcl8.5  -O2 -pipe -O0 -g -std=c++11 -Wall -Wextra -Wno-ignored-qualifiers -Wno-unused-parameter -feliminate-unused-debug-symbols -fno-strict-aliasing -Wno-invalid-offsetof -fPIE -fstack-protector -mcx16 -MT BaseLogFile.lo -MD -MP -MF $depbase.Tpo -c -o BaseLogFile.lo BaseLogFile.cc &&\
mv -f $depbase.Tpo $depbase.Plo
c++ -DHAVE_CONFIG_H -I. -I../../lib -I/home/jirib/openbsd/pobj/trafficserver-20170106/trafficserver-24347df553e91660b794af1079fbf69f986dc5b4/lib -I/usr/local/include -Dopenbsd -D_LARGEFILE64_SOURCE=1 -D_COMPILE64BIT_SOURCE=1 -D_GNU_SOURCE -D_REENTRANT -D__STDC_LIMIT_MACROS=1 -D__STDC_FORMAT_MACROS=1 -D_FORTIFY_SOURCE=2 -I/usr/include -DOPENSSL_NO_SSL_INTERN -I/usr/local/include/tcl8.5 -O2 -pipe -O0 -g -std=c++11 -Wall -Wextra -Wno-ignored-qualifiers -Wno-unused-parameter -feliminate-unused-debug-symbols -fno-strict-aliasing -Wno-invalid-offsetof -fstack-protector -mcx16 -MT BaseLogFile.lo -MD -MP -MF .deps/BaseLogFile.Tpo -c BaseLogFile.cc -fPIC -DPIC -o .libs/BaseLogFile.o
BaseLogFile.cc: In member function 'int BaseLogFile::roll()':
BaseLogFile.cc:244:61: error: invalid conversion from 'long int*' to 'time_t* {aka long long int*}' [-fpermissive]
   if (!m_meta_info || !m_meta_info->get_creation_time(&start))
                                                             ^
In file included from BaseLogFile.cc:24:0:
BaseLogFile.h:126:3: note: initializing argument 1 of 'bool BaseMetaInfo::get_creation_time(time_t*)'
   get_creation_time(time_t *time)
   ^
Error while executing c++ -DHAVE_CONFIG_H -I. -I../../lib -I/home/jirib/openbsd/pobj/trafficserver-20170106/trafficserver-24347df553e91660b794af1079fbf69f986dc5b4/lib -I/usr/local/include -Dopenbsd -D_LARGEFILE64_SOURCE=1 -D_COMPILE64BIT_SOURCE=1 -D_GNU_SOURCE -D_REENTRANT -D__STDC_LIMIT_MACROS=1 -D__STDC_FORMAT_MACROS=1 -D_FORTIFY_SOURCE=2 -I/usr/include -DOPENSSL_NO_SSL_INTERN -I/usr/local/include/tcl8.5 -O2 -pipe -O0
-g -std=c++11 -Wall -Wextra -Wno-ignored-qualifiers -Wno-unused-parameter -feliminate-unused-debug-symbols -fno-strict-aliasing -Wno-invalid-offsetof -fstack-protector -mcx16 -MT BaseLogFile.lo -MD -MP -MF .deps/BaseLogFile.Tpo -c BaseLogFile.cc -fPIC -DPIC -o .libs/BaseLogFile.o

[jirib]

I used gcc 4.9.4.

lrwxr-xr-x  1 jirib  jirib   19 Jan  9 13:20 c++@ -> /usr/local/bin/eg++
lrwxr-xr-x  1 jirib  jirib   19 Jan  9 13:20 cc@ -> /usr/local/bin/egcc
lrwxr-xr-x  1 jirib  jirib   19 Jan  9 13:20 g++@ -> /usr/local/bin/eg++
lrwxr-xr-x  1 jirib  jirib   19 Jan  9 13:20 gcc@ -> /usr/local/bin/egcc
-rwxr-xr-x  1 jirib  jirib  438 Jan  9 13:20 install*
lrwxr-xr-x  1 jirib  jirib    6 Jan  9 13:20 msgcat@ -> msgfmt
-r-xr-xr-x  1 jirib  jirib   85 Jan  9 13:20 msgfmt*
lrwxr-xr-x  1 jirib  jirib    6 Jan  9 13:20 msginit@ -> msgfmt

$ ec++ -v                                   
Using built-in specs.
COLLECT_GCC=ec++
COLLECT_LTO_WRAPPER=/usr/local/libexec/gcc/x86_64-unknown-openbsd6.0/4.9.4/lto-wrapper
Target: x86_64-unknown-openbsd6.0
Configured with: /usr/obj/ports/gcc-4.9.4/gcc-4.9.4/configure --enable-libgcj --without-jar --verbose --program-transform-name='s,^,e,' --disable-nls --with-system-zlib --disable-libmudflap --disable-libgomp --disable-tls --with-gnu-ld --with-gnu-as --enable-threads=posix --enable-wchar_t --with-gmp=/usr/local --enable-languages=c,c++,fortran,objc,java,ada --disable-libstdcxx-pch --enable-cpp --prefix=/usr/local --sysconfdir=/etc --mandir=/usr/local/man --infodir=/usr/local/info --localstatedir=/var --disable-silent-rules --disable-gtk-doc
Thread model: posix
gcc version 4.9.4 (GCC)

[jirib]

Is this right for OpenBSD? It passes this issue.

--- lib/ts/BaseLogFile.cc.orig  Mon Jan  9 16:05:20 2017
+++ lib/ts/BaseLogFile.cc       Mon Jan  9 16:05:39 2017
@@ -238,7 +238,7 @@ BaseLogFile::roll(long interval_start, long interval_e
 int
 BaseLogFile::roll()
 {
-  long start;
+  time_t start;
   time_t now = time(nullptr);

   if (!m_meta_info || !m_meta_info->get_creation_time(&start))

[jablko]

@jirib That makes sense to me, the signature of BaseMetaInfo::get_creation_time() is *time_t.